fix(plugin-chart-pivot-table): pivot table supports single select (#1221

)
apache · Nov 26, 2021 · 89474f8 · 89474f8
1 parent 844c069
commit 89474f8
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/...emporary_superset_ui/superset-ui/plugins/plugin-chart-pivot-table/src/PivotTableChart.tsx b/...emporary_superset_ui/superset-ui/plugins/plugin-chart-pivot-table/src/PivotTableChart.tsx
@@ -172,11 +172,20 @@ export default function PivotTableChart(props: PivotTableProps) {
 
       const [key, val] = filtersEntries[filtersEntries.length - 1];
 
-      const updatedFilters = { ...(selectedFilters || {}) };
+      let updatedFilters = { ...(selectedFilters || {}) };
+      // multi select
+      // if (selectedFilters && isActiveFilterValue(key, val)) {
+      //   updatedFilters[key] = selectedFilters[key].filter((x: DataRecordValue) => x !== val);
+      // } else {
+      //   updatedFilters[key] = [...(selectedFilters?.[key] || []), val];
+      // }
+      // single select
       if (selectedFilters && isActiveFilterValue(key, val)) {
-        updatedFilters[key] = selectedFilters[key].filter((x: DataRecordValue) => x !== val);
+        updatedFilters = {};
       } else {
-        updatedFilters[key] = [...(selectedFilters?.[key] || []), val];
+        updatedFilters = {
+          [key]: [val],
+        };
       }
       if (Array.isArray(updatedFilters[key]) && updatedFilters[key].length === 0) {
         delete updatedFilters[key];