Skip to content

Commit

Permalink
chore(pylint): Re-enable super-with-arguments check (#16138)
Browse files Browse the repository at this point in the history
Co-authored-by: John Bodley <john.bodley@airbnb.com>
  • Loading branch information
john-bodley and john-bodley committed Aug 16, 2021
1 parent ee9a384 commit 8e07dd2
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
1 change: 0 additions & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ disable=
ungrouped-imports,
import-outside-toplevel,
raise-missing-from,
super-with-arguments,
too-few-public-methods,
too-many-locals,
duplicate-code,
Expand Down
4 changes: 2 additions & 2 deletions superset/tasks/cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ class TopNDashboardsStrategy(Strategy):
name = "top_n_dashboards"

def __init__(self, top_n: int = 5, since: str = "7 days ago") -> None:
super(TopNDashboardsStrategy, self).__init__()
super().__init__()
self.top_n = top_n
self.since = parse_human_datetime(since) if since else None

Expand Down Expand Up @@ -206,7 +206,7 @@ class DashboardTagsStrategy(Strategy):
name = "dashboard_tags"

def __init__(self, tags: Optional[List[str]] = None) -> None:
super(DashboardTagsStrategy, self).__init__()
super().__init__()
self.tags = tags or []

def get_urls(self) -> List[str]:
Expand Down
2 changes: 1 addition & 1 deletion superset/utils/url_map_converters.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

class RegexConverter(BaseConverter):
def __init__(self, url_map: Map, *items: List[str]) -> None:
super(RegexConverter, self).__init__(url_map) # type: ignore
super().__init__(url_map) # type: ignore
self.regex = items[0]


Expand Down
4 changes: 2 additions & 2 deletions superset/views/schedules.py
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def list(self) -> FlaskResponse:
def pre_add(self, item: "DashboardEmailScheduleView") -> None:
if item.dashboard is None:
raise SupersetException("Dashboard is mandatory")
super(DashboardEmailScheduleView, self).pre_add(item)
super().pre_add(item)


class SliceEmailScheduleView(EmailScheduleView): # pylint: disable=too-many-ancestors
Expand Down Expand Up @@ -348,4 +348,4 @@ def list(self) -> FlaskResponse:
def pre_add(self, item: "SliceEmailScheduleView") -> None:
if item.slice is None:
raise SupersetException("Slice is mandatory")
super(SliceEmailScheduleView, self).pre_add(item)
super().pre_add(item)

0 comments on commit 8e07dd2

Please sign in to comment.