fix(core): missing translation (#1144)

apache · Nov 26, 2021 · 9227b1e · 9227b1e
1 parent 25ec1e3
commit 9227b1e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/...rset_ui/superset-ui/packages/superset-ui-core/src/chart/components/NoResultsComponent.tsx b/...rset_ui/superset-ui/packages/superset-ui-core/src/chart/components/NoResultsComponent.tsx
@@ -1,11 +1,10 @@
 import React, { CSSProperties, useMemo } from 'react';
+import { t } from '../../translation';
 
 const MESSAGE_STYLES: CSSProperties = { maxWidth: 800 };
 const TITLE_STYLES: CSSProperties = { fontSize: 16, fontWeight: 'bold', paddingBottom: 8 };
 const BODY_STYLES: CSSProperties = { fontSize: 14 };
 const MIN_WIDTH_FOR_BODY = 250;
-const BODY_STRING =
-  'No results were returned for this query. If you expected results to be returned, ensure any filters are configured properly and the datasource contains data for the selected time range.';
 
 const generateContainerStyles: (
   height: number | string,
@@ -34,6 +33,10 @@ const NoResultsComponent = ({ className, height, id, width }: Props) => {
   // render the body if the width is auto/100% or greater than 250 pixels
   const shouldRenderBody = typeof width === 'string' || width > MIN_WIDTH_FOR_BODY;
 
+  const BODY_STRING = t(
+    'No results were returned for this query. If you expected results to be returned, ensure any filters are configured properly and the datasource contains data for the selected time range.',
+  );
+
   return (
     <div
       className={className}
@@ -42,7 +45,7 @@ const NoResultsComponent = ({ className, height, id, width }: Props) => {
       title={shouldRenderBody ? undefined : BODY_STRING}
     >
       <div style={MESSAGE_STYLES}>
-        <div style={TITLE_STYLES}>No Results</div>
+        <div style={TITLE_STYLES}>{t('No Results')}</div>
         {shouldRenderBody && <div style={BODY_STYLES}>{BODY_STRING}</div>}
       </div>
     </div>

diff --git a/...i/superset-ui/packages/superset-ui-core/test/chart/components/NoResultsComponent.test.tsx b/...i/superset-ui/packages/superset-ui-core/test/chart/components/NoResultsComponent.test.tsx
@@ -1,6 +1,9 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 import NoResultsComponent from '@superset-ui/core/src/chart/components/NoResultsComponent';
+import { configure } from '@superset-ui/core/src';
+
+configure();
 
 describe('NoResultsComponent', () => {
   it('renders the no results error', () => {