feat: Remove legacy sql alchemy db connection link from G Sheet conne…

…ction (#19450) * feat: Remove legacy sql alchemy db connection link from G Sheet connection * resolve comment
apache · Apr 14, 2022 · 9407598 · 9407598
1 parent 158852d
commit 9407598
Showing 1 changed file with 32 additions and 26 deletions.
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
@@ -139,6 +139,8 @@ const errorAlertMapping = {
     ),
   },
 };
+const googleSheetConnectionEngine = 'gsheets';
+
 interface DatabaseModalProps {
   addDangerToast: (msg: string) => void;
   addSuccessToast: (msg: string) => void;
@@ -1575,32 +1577,36 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
                   validationErrors={validationErrors}
                 />
                 <div css={(theme: SupersetTheme) => infoTooltip(theme)}>
-                  <Button
-                    data-test="sqla-connect-btn"
-                    buttonStyle="link"
-                    onClick={() =>
-                      setDB({
-                        type: ActionType.configMethodChange,
-                        payload: {
-                          engine: db.engine,
-                          configuration_method:
-                            CONFIGURATION_METHOD.SQLALCHEMY_URI,
-                          database_name: db.database_name,
-                        },
-                      })
-                    }
-                    css={buttonLinkStyles}
-                  >
-                    {t(
-                      'Connect this database with a SQLAlchemy URI string instead',
-                    )}
-                  </Button>
-                  <InfoTooltip
-                    tooltip={t(
-                      'Click this link to switch to an alternate form that allows you to input the SQLAlchemy URL for this database manually.',
-                    )}
-                    viewBox="0 -6 24 24"
-                  />
+                  {dbModel.engine !== googleSheetConnectionEngine && (
+                    <>
+                      <Button
+                        data-test="sqla-connect-btn"
+                        buttonStyle="link"
+                        onClick={() =>
+                          setDB({
+                            type: ActionType.configMethodChange,
+                            payload: {
+                              engine: db.engine,
+                              configuration_method:
+                                CONFIGURATION_METHOD.SQLALCHEMY_URI,
+                              database_name: db.database_name,
+                            },
+                          })
+                        }
+                        css={buttonLinkStyles}
+                      >
+                        {t(
+                          'Connect this database with a SQLAlchemy URI string instead',
+                        )}
+                      </Button>
+                      <InfoTooltip
+                        tooltip={t(
+                          'Click this link to switch to an alternate form that allows you to input the SQLAlchemy URL for this database manually.',
+                        )}
+                        viewBox="0 -6 24 24"
+                      />
+                    </>
+                  )}
                 </div>
                 {/* Step 2 */}
                 {showDBError && errorAlert()}