Skip to content

Commit

Permalink
Replace NaN/Infinity with null (#4908)
Browse files Browse the repository at this point in the history
  • Loading branch information
betodealmeida authored and mistercrunch committed May 1, 2018
1 parent 8c94e1f commit 9c53323
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions superset/views/core.py
Expand Up @@ -6,7 +6,6 @@
from __future__ import unicode_literals

from datetime import datetime, timedelta
import json
import logging
import os
import re
Expand All @@ -24,6 +23,7 @@
from flask_babel import gettext as __
from flask_babel import lazy_gettext as _
import pandas as pd
import simplejson as json
from six import text_type
import sqlalchemy as sqla
from sqlalchemy import create_engine
Expand Down Expand Up @@ -2327,7 +2327,8 @@ def results(self, key):
payload_json = json.loads(payload)
payload_json['data'] = payload_json['data'][:display_limit]
return json_success(
json.dumps(payload_json, default=utils.json_iso_dttm_ser))
json.dumps(
payload_json, default=utils.json_iso_dttm_ser, ignore_nan=True))

@has_access_api
@expose('/stop_query/', methods=['POST'])
Expand Down Expand Up @@ -2435,7 +2436,7 @@ def sql_json(self):

resp = json_success(json.dumps(
{'query': query.to_dict()}, default=utils.json_int_dttm_ser,
allow_nan=False), status=202)
ignore_nan=True), status=202)
session.commit()
return resp

Expand All @@ -2453,7 +2454,7 @@ def sql_json(self):
rendered_query,
return_results=True)
payload = json.dumps(
data, default=utils.pessimistic_json_iso_dttm_ser)
data, default=utils.pessimistic_json_iso_dttm_ser, ignore_nan=True)
except Exception as e:
logging.exception(e)
return json_error_response('{}'.format(e))
Expand Down

0 comments on commit 9c53323

Please sign in to comment.