fix: make translation module type check correctly (#140)

apache · Nov 26, 2021 · a35f88a · a35f88a
1 parent 368ed3c
commit a35f88a
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/...orary_superset_ui/superset-ui/packages/superset-ui-translation/src/TranslatorSingleton.ts b/...orary_superset_ui/superset-ui/packages/superset-ui-translation/src/TranslatorSingleton.ts
@@ -3,7 +3,7 @@
 import Translator from './Translator';
 import { TranslatorConfig } from './types';
 
-let singleton: Translator;
+let singleton: Translator | undefined;
 let isConfigured = false;
 
 function configure(config?: TranslatorConfig) {
@@ -15,10 +15,11 @@ function configure(config?: TranslatorConfig) {
 
 function getInstance() {
   if (!isConfigured) {
-    console.warn('You must call configure(...) before calling other methods');
-    if (!singleton) {
-      singleton = new Translator();
-    }
+    console.warn('You should call configure(...) before calling other methods');
+  }
+
+  if (typeof singleton === 'undefined') {
+    singleton = new Translator();
   }
 
   return singleton;