fix(dashboard): fix Pivot Table V2 dragPreview in the dashboard (#21539)

apache · Sep 28, 2022 · ab53d77 · ab53d77
1 parent 60bab42
commit ab53d77
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.js b/superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.js
@@ -20,9 +20,9 @@
 import { css, styled } from '@superset-ui/core';
 
 export const Styles = styled.div`
-  ${({ theme }) => css`
+  ${({ theme, isDashboardEditMode }) => css`
     table.pvtTable {
-      position: relative;
+      position: ${isDashboardEditMode ? 'inherit' : 'relative'};
       font-size: ${theme.typography.sizes.s}px;
       text-align: left;
       margin: ${theme.gridUnit}px;
@@ -32,7 +32,7 @@ export const Styles = styled.div`
     }
 
     table thead {
-      position: sticky;
+      position: ${isDashboardEditMode ? 'inherit' : 'sticky'};
       top: 0;
     }
 
@@ -51,7 +51,7 @@ export const Styles = styled.div`
     }
 
     table.pvtTable tbody tr.pvtRowTotals {
-      position: sticky;
+      position: ${isDashboardEditMode ? 'inherit' : 'sticky'};
       bottom: 0;
     }
 

diff --git a/superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx b/superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx
@@ -826,6 +826,10 @@ export class TableRenderer extends React.Component {
     );
   }
 
+  isDashboardEditMode() {
+    return document.contains(document.querySelector('.dashboard--editing'));
+  }
+
   render() {
     if (this.cachedProps !== this.props) {
       this.cachedProps = this.props;
@@ -867,7 +871,7 @@ export class TableRenderer extends React.Component {
     };
 
     return (
-      <Styles>
+      <Styles isDashboardEditMode={this.isDashboardEditMode()}>
         <table className="pvtTable" role="grid">
           <thead>
             {colAttrs.map((c, j) =>