fix: suppress translation warning in jest

apache · Jun 21, 2022 · ad82ce6 · ad82ce6
1 parent c79b0d6
commit ad82ce6
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 8 deletions.
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
diff --git a/superset-frontend/packages/superset-ui-core/package.json b/superset-frontend/packages/superset-ui-core/package.json
@@ -40,6 +40,7 @@
     "@types/d3-time-format": "^2.1.0",
     "@types/lodash": "^4.14.149",
     "@types/math-expression-evaluator": "^1.2.1",
+    "@types/node": "^18.0.0",
     "@types/rison": "0.0.6",
     "@types/seedrandom": "^2.4.28",
     "@types/fetch-mock": "^7.3.3",

diff --git a/superset-frontend/packages/superset-ui-core/src/translation/Translator.ts b/superset-frontend/packages/superset-ui-core/src/translation/Translator.ts
@@ -56,7 +56,7 @@ export default class Translator {
    */
   addTranslation(key: string, texts: ReadonlyArray<string>) {
     const translations = this.i18n.options.locale_data.superset;
-    if (key in translations) {
+    if (process?.env?.NODE_ENV !== 'test' && key in translations) {
       logging.warn(`Duplicate translation key "${key}", will override.`);
     }
     translations[key] = texts;

diff --git a/superset-frontend/packages/superset-ui-core/test/translation/Translator.test.ts b/superset-frontend/packages/superset-ui-core/test/translation/Translator.test.ts
@@ -41,10 +41,12 @@ describe('Translator', () => {
     spy.mockImplementation((info: any) => {
       throw new Error(info);
     });
+    process.env.NODE_ENV = 'production';
   });
 
   afterAll(() => {
     spy.mockRestore();
+    process.env.NODE_ENV = 'test';
   });
 
   describe('new Translator(config)', () => {

diff --git a/superset-frontend/tsconfig.json b/superset-frontend/tsconfig.json
@@ -29,7 +29,8 @@
     "types": [
       "@emotion/react/types/css-prop",
       "jest",
-      "@testing-library/jest-dom"
+      "@testing-library/jest-dom",
+      "@types/node"
     ],
 
     /* Emit */