fix: Pin snowflake-sqlalchemy to 1.2.4 (#16515)

* Pin snowflake-sqlalchemy to 1.2.4 * lint files
apache · Aug 31, 2021 · ad8336a · ad8336a
1 parent e246916
commit ad8336a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/docs/src/pages/docs/Connecting to Databases/snowflake.mdx b/docs/src/pages/docs/Connecting to Databases/snowflake.mdx
@@ -9,7 +9,7 @@ version: 1
 ## Snowflake
 
 The recommended connector library for Snowflake is
-[snowflake-sqlalchemy](https://pypi.org/project/snowflake-sqlalchemy/).
+[snowflake-sqlalchemy](https://pypi.org/project/snowflake-sqlalchemy/1.2.4/)<=1.2.4. (This version is required until Superset migrates to sqlalchemy>=1.4.0)
 
 The connection string for Snowflake looks like this:
 

diff --git a/setup.py b/setup.py
@@ -151,7 +151,9 @@ def get_git_sha() -> str:
         "shillelagh": [
             "shillelagh[datasetteapi,gsheetsapi,socrata,weatherapi]>=1.0.3, <2"
         ],
-        "snowflake": ["snowflake-sqlalchemy>=1.2.3, <1.3"],
+        "snowflake": [
+            "snowflake-sqlalchemy>=1.2.4"
+        ],  # PINNED! 1.2.5 introduced breaking changes requiring sqlalchemy>=1.4.0
         "teradata": ["sqlalchemy-teradata==0.9.0.dev0"],
         "thumbnails": ["Pillow>=7.0.0, <8.0.0"],
         "vertica": ["sqlalchemy-vertica-python>=0.5.9, < 0.6"],