fix: pass all props to transformProps in LineMulti chart (#247)

apache · Nov 26, 2021 · ade25f4 · ade25f4
1 parent 180c72b
commit ade25f4
Showing 1 changed file with 6 additions and 22 deletions.
diff --git a/...rset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/LineMulti/LineMulti.jsx b/...rset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/LineMulti/LineMulti.jsx
@@ -31,13 +31,12 @@ const propTypes = {
   annotationData: PropTypes.object,
   datasource: PropTypes.object,
   formData: PropTypes.object,
-  onAddFilter: PropTypes.func,
-  onError: PropTypes.func,
-};
-const defaultProps = {
-  onAddFilter() {},
-  onError() {},
+  hooks: PropTypes.shape({
+    onAddFilter: PropTypes.func,
+    onError: PropTypes.func,
+  }),
 };
+const defaultProps = {};
 
 function getJson(url) {
   return new Promise((resolve, reject) => {
@@ -137,27 +136,12 @@ class LineMulti extends React.Component {
   }
 
   render() {
-    const {
-      width,
-      height,
-      annotationData,
-      datasource,
-      formData,
-      onAddFilter,
-      onError,
-    } = this.props;
     const { queryData } = this.state;
 
     return (
       <ReactNVD3
         {...transformProps({
-          width,
-          height,
-          annotationData,
-          datasource,
-          formData,
-          onError,
-          onAddFilter,
+          ...this.props,
           queryData,
         })}
       />