Make cell-click filter in table viz optional

- Added table_filter checkbox in table viz - If set to false, clicking on a cell in table will not apply filter to dashboard
apache · Dec 5, 2016 · b910ef3 · b910ef3
1 parent 2d0ebea
commit b910ef3
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/superset/assets/javascripts/explorev2/stores/store.js b/superset/assets/javascripts/explorev2/stores/store.js
@@ -264,7 +264,7 @@ export const visTypes = {
           ['table_timestamp_format'],
           ['row_limit'],
           ['page_length'],
-          ['include_search'],
+          ['include_search', 'table_filter'],
         ],
       },
     ],
@@ -1462,6 +1462,13 @@ export const fields = {
     description: 'Whether to include a client side search box',
   },
 
+  table_filter: {
+    type: 'CheckboxField',
+    label: 'Table Filter',
+    default: true,
+    description: 'Whether to apply filter when table cell is clicked',
+  },
+
   show_bubbles: {
     type: 'CheckboxField',
     label: 'Show Bubbles',

diff --git a/superset/assets/visualizations/table.js b/superset/assets/visualizations/table.js
@@ -106,7 +106,7 @@ function tableVis(slice) {
           return (d.isMetric) ? d.val : null;
         })
         .on('click', function (d) {
-          if (!d.isMetric) {
+          if (!d.isMetric && fd.table_filter) {
             const td = d3.select(this);
             if (td.classed('filtered')) {
               slice.removeFilter(d.col, [d.val]);

diff --git a/superset/forms.py b/superset/forms.py
@@ -784,6 +784,11 @@ def __init__(self, viz):
                 "description": _(
                     "Whether to include a client side search box")
             }),
+            'table_filter': (BetterBooleanField, {
+                "label": _("Table Filter"),
+                "default": True,
+                "description": _("Whether to apply filter when table cell is clicked")
+            }),
             'show_bubbles': (BetterBooleanField, {
                 "label": _("Show Bubbles"),
                 "default": False,

diff --git a/superset/viz.py b/superset/viz.py
@@ -421,7 +421,7 @@ class TableViz(BaseViz):
             'table_timestamp_format',
             'row_limit',
             'page_length',
-            ('include_search', None),
+            ('include_search', 'table_filter'),
         )
     })
     form_overrides = ({