Skip to content

Commit

Permalink
refactor: migrate SliderControl to TypeScript & added story (#18120)
Browse files Browse the repository at this point in the history
* refactor: migrate SliderControl to TypeScript & added story

* fix: Set default onChange in SliderControl
  • Loading branch information
ad-m committed Feb 10, 2022
1 parent 8212975 commit bd0b9f2
Show file tree
Hide file tree
Showing 2 changed files with 53 additions and 14 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import SliderControl from './SliderControl';

export default {
title: 'SliderControl',
component: SliderControl,
};

const options = {
value: {
value: 25,
},
default: {
default: 50,
},
};

export const SliderControlGallery = () => (
<>
{Object.keys(options).map(name => (
<>
<h4>{name}</h4>
<SliderControl {...options[name]} />
</>
))}
</>
);
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,21 @@
* under the License.
*/
import React from 'react';
import PropTypes from 'prop-types';
import Slider from 'src/components/Slider';
import ControlHeader from 'src/explore/components/ControlHeader';

const propTypes = {
onChange: PropTypes.func,
value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
type SliderControlProps = {
onChange: (value: number) => void;
value: number;
default?: number;
};

const defaultProps = {
onChange: () => {},
};

export default function SliderControl(props) {
export default function SliderControl(props: SliderControlProps) {
const { onChange = () => {}, default: defaultValue, ...rest } = props;
return (
<>
<ControlHeader {...props} />
<Slider {...props} defaultValue={props.default} />
<ControlHeader />
<Slider {...rest} onChange={onChange} defaultValue={defaultValue} />
</>
);
}

SliderControl.propTypes = propTypes;
SliderControl.defaultProps = defaultProps;

0 comments on commit bd0b9f2

Please sign in to comment.