fix(plugin-chart-echarts): fix unnecessary highlight (#1052)

* fix(plugin-chart-echarts): fix unnecessary highlight * simplify code Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
apache · Nov 26, 2021 · cca4b74 · cca4b74
1 parent 1dc7538
commit cca4b74
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/.../temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/components/Echart.tsx b/.../temporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/components/Echart.tsx
@@ -55,10 +55,12 @@ export default function Echart({
       type: 'downplay',
       dataIndex: previousSelection.current.filter(value => !currentSelection.includes(value)),
     });
-    chartRef.current.dispatchAction({
-      type: 'highlight',
-      dataIndex: currentSelection,
-    });
+    if (currentSelection.length) {
+      chartRef.current.dispatchAction({
+        type: 'highlight',
+        dataIndex: currentSelection,
+      });
+    }
     previousSelection.current = currentSelection;
   }, [echartOptions, eventHandlers, selectedValues]);