Fix linter errors

apache · Apr 1, 2022 · ced4cea · ced4cea
1 parent 34820b4
commit ced4cea
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 50 deletions.
diff --git a/superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx b/superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
@@ -241,13 +241,13 @@ function DashboardList(props: DashboardListProps) {
             original: { id },
           },
         }: any) =>
-          userId ? (
+          userId && (
             <FaveStar
               itemId={id}
               saveFaveStar={saveFavoriteStatus}
               isStarred={favoriteStatus[id]}
             />
-          ) : null,
+          ),
         Header: '',
         id: 'id',
         disableSortBy: true,

diff --git a/superset-frontend/src/views/CRUD/utils.tsx b/superset-frontend/src/views/CRUD/utils.tsx
@@ -64,57 +64,60 @@ import { Dashboard, Filters } from './types';
   risonRef.next_id = new RegExp(idrx, 'g');
 })();
 
-const createFetchResourceMethod = (method: string) => (
-  resource: string,
-  relation: string,
-  handleError: (error: Response) => void,
-  user?: { userId: string | number; firstName: string; lastName: string },
-) => async (filterValue = '', page: number, pageSize: number) => {
-  const resourceEndpoint = `/api/v1/${resource}/${method}/${relation}`;
-  const queryParams = rison.encode_uri({
-    filter: filterValue,
-    page,
-    page_size: pageSize,
-  });
-  const { json = {} } = await SupersetClient.get({
-    endpoint: `${resourceEndpoint}?q=${queryParams}`,
-  });
-
-  let fetchedLoggedUser = false;
-  const loggedUser = user
-    ? {
-        label: `${user.firstName} ${user.lastName}`,
-        value: user.userId,
-      }
-    : undefined;
-
-  const data: { label: string; value: string | number }[] = [];
-  json?.result?.forEach(
-    ({ text, value }: { text: string; value: string | number }) => {
-      if (
-        loggedUser &&
-        value === loggedUser.value &&
-        text === loggedUser.label
-      ) {
-        fetchedLoggedUser = true;
-      } else {
-        data.push({
-          label: text,
-          value,
-        });
-      }
-    },
-  );
+const createFetchResourceMethod =
+  (method: string) =>
+  (
+    resource: string,
+    relation: string,
+    handleError: (error: Response) => void,
+    user?: { userId: string | number; firstName: string; lastName: string },
+  ) =>
+  async (filterValue = '', page: number, pageSize: number) => {
+    const resourceEndpoint = `/api/v1/${resource}/${method}/${relation}`;
+    const queryParams = rison.encode_uri({
+      filter: filterValue,
+      page,
+      page_size: pageSize,
+    });
+    const { json = {} } = await SupersetClient.get({
+      endpoint: `${resourceEndpoint}?q=${queryParams}`,
+    });
+
+    let fetchedLoggedUser = false;
+    const loggedUser = user
+      ? {
+          label: `${user.firstName} ${user.lastName}`,
+          value: user.userId,
+        }
+      : undefined;
+
+    const data: { label: string; value: string | number }[] = [];
+    json?.result?.forEach(
+      ({ text, value }: { text: string; value: string | number }) => {
+        if (
+          loggedUser &&
+          value === loggedUser.value &&
+          text === loggedUser.label
+        ) {
+          fetchedLoggedUser = true;
+        } else {
+          data.push({
+            label: text,
+            value,
+          });
+        }
+      },
+    );
 
-  if (loggedUser && (!filterValue || fetchedLoggedUser)) {
-    data.unshift(loggedUser);
-  }
+    if (loggedUser && (!filterValue || fetchedLoggedUser)) {
+      data.unshift(loggedUser);
+    }
 
-  return {
-    data,
-    totalCount: json?.count,
+    return {
+      data,
+      totalCount: json?.count,
+    };
   };
-};
 
 export const PAGE_SIZE = 5;
 const getParams = (filters?: Array<Filters>) => {