Skip to content

Commit

Permalink
lint fix
Browse files Browse the repository at this point in the history
  • Loading branch information
kgabryje committed Oct 18, 2021
1 parent 4fc7136 commit cf328e6
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,7 @@ const FilterControls: FC<FilterControlsProps> = ({
{portalNodes
.filter((node, index) => cascadeFilterIds.has(filterValues[index].id))
.map((node, index) => (
<InPortal node={node}>
{cascadePopoverFactory(index)}
</InPortal>
<InPortal node={node}>{cascadePopoverFactory(index)}</InPortal>
))}
{filtersInScope.map(filter => {
const index = filterValues.findIndex(f => f.id === filter.id);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,28 +162,29 @@ const FilterBar: React.FC<FiltersBarProps> = ({
const previousFilters = usePrevious(filters);
const filterValues = Object.values<Filter>(filters);

const handleFilterSelectionChange = useCallback((
filter: Pick<Filter, 'id'> & Partial<Filter>,
dataMask: Partial<DataMask>,
) => {
setDataMaskSelected(draft => {
// force instant updating on initialization for filters with `requiredFirst` is true or instant filters
if (
// filterState.value === undefined - means that value not initialized
dataMask.filterState?.value !== undefined &&
dataMaskSelected[filter.id]?.filterState?.value === undefined &&
filter.requiredFirst
) {
dispatch(updateDataMask(filter.id, dataMask));
}
const handleFilterSelectionChange = useCallback(
(
filter: Pick<Filter, 'id'> & Partial<Filter>,
dataMask: Partial<DataMask>,
) => {
setDataMaskSelected(draft => {
// force instant updating on initialization for filters with `requiredFirst` is true or instant filters
if (
// filterState.value === undefined - means that value not initialized
dataMask.filterState?.value !== undefined &&
dataMaskSelected[filter.id]?.filterState?.value === undefined &&
filter.requiredFirst
) {
dispatch(updateDataMask(filter.id, dataMask));
}

draft[filter.id] = {
...(getInitialDataMask(filter.id) as DataMaskWithId),
...dataMask,
};
});
},
[dataMaskSelected, dispatch, setDataMaskSelected, tab]
[dataMaskSelected, dispatch, setDataMaskSelected, tab],
);

const publishDataMask = useCallback(
Expand Down

0 comments on commit cf328e6

Please sign in to comment.