Skip to content

Commit

Permalink
fix: add form data for empty state control to save dataset (#21944)
Browse files Browse the repository at this point in the history
  • Loading branch information
pkdotson committed Oct 28, 2022
1 parent 7f563cf commit d3f930a
Showing 1 changed file with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,20 @@ export interface ISimpleColumn {
is_dttm?: boolean | null;
}

export type Database = {
backend: string;
id: number;
parameter: object;
};

export interface ISaveableDatasource {
columns: ISimpleColumn[];
name: string;
dbId: number;
sql: string;
templateParams?: string | object | null;
schema?: string | null;
database?: Database;
}

interface SaveDatasetModalProps {
Expand Down Expand Up @@ -283,7 +290,7 @@ export const SaveDatasetModal = ({
createDatasource({
schema: datasource.schema,
sql: datasource.sql,
dbId: datasource.dbId,
dbId: datasource.dbId || datasource?.database?.id,
templateParams,
datasourceName: datasetName,
columns: selectedColumns,
Expand Down

0 comments on commit d3f930a

Please sign in to comment.