fix(plugin-chart-handlebars): Update webpack/babel config to fix buil…

…d/runtime warnings/errors (#21779)
apache · Oct 13, 2022 · d5b4bde · d5b4bde
1 parent 3936e9e
commit d5b4bde
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/superset-frontend/babel.config.js b/superset-frontend/babel.config.js
@@ -103,4 +103,10 @@ module.exports = {
       plugins: [],
     },
   },
+  overrides: [
+    {
+      test: './plugins/plugin-chart-handlebars/node_modules/just-handlebars-helpers/*',
+      sourceType: 'unambiguous',
+    },
+  ],
 };
diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js
@@ -289,6 +289,9 @@ const config = {
       //  AntD version conflict has been resolved
       antd: path.resolve(path.join(APP_DIR, './node_modules/antd')),
       react: path.resolve(path.join(APP_DIR, './node_modules/react')),
+      // TODO: remove Handlebars alias once Handlebars NPM package has been updated to
+      // correctly support webpack import (https://github.com/handlebars-lang/handlebars.js/issues/953)
+      handlebars: 'handlebars/dist/handlebars.js',
     },
     extensions: ['.ts', '.tsx', '.js', '.jsx', '.yml'],
     fallback: {