make codecov happy

apache · Jun 18, 2022 · d7974f1 · d7974f1
1 parent 88a6dfa
commit d7974f1
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 24 deletions.
diff --git a/superset-frontend/packages/superset-ui-core/src/connection/SupersetClientClass.ts b/superset-frontend/packages/superset-ui-core/src/connection/SupersetClientClass.ts
@@ -120,32 +120,33 @@ export default class SupersetClientClass {
   }
 
   async postForm(url: string, payload: Record<string, any>, target = '_blank') {
-    if (!url) return;
-    await this.ensureAuth();
-    const hiddenForm = document.createElement('form');
-    hiddenForm.action = url;
-    hiddenForm.method = 'POST';
-    hiddenForm.target = target;
-    const payloadWithToken: Record<string, any> = {
-      ...payload,
-      csrf_token: this.csrfToken!,
-    };
+    if (url) {
+      await this.ensureAuth();
+      const hiddenForm = document.createElement('form');
+      hiddenForm.action = url;
+      hiddenForm.method = 'POST';
+      hiddenForm.target = target;
+      const payloadWithToken: Record<string, any> = {
+        ...payload,
+        csrf_token: this.csrfToken!,
+      };
+
+      if (this.guestToken) {
+        payloadWithToken.guest_token = this.guestToken;
+      }
 
-    if (this.guestToken) {
-      payloadWithToken.guest_token = this.guestToken;
+      Object.entries(payloadWithToken).forEach(([key, value]) => {
+        const data = document.createElement('input');
+        data.type = 'hidden';
+        data.name = key;
+        data.value = value;
+        hiddenForm.appendChild(data);
+      });
+
+      document.body.appendChild(hiddenForm);
+      hiddenForm.submit();
+      document.body.removeChild(hiddenForm);
     }
-
-    Object.entries(payloadWithToken).forEach(([key, value]) => {
-      const data = document.createElement('input');
-      data.type = 'hidden';
-      data.name = key;
-      data.value = value;
-      hiddenForm.appendChild(data);
-    });
-
-    document.body.appendChild(hiddenForm);
-    hiddenForm.submit();
-    document.body.removeChild(hiddenForm);
   }
 
   async reAuthenticate() {

diff --git a/superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts b/superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts
@@ -614,6 +614,7 @@ describe('SupersetClientClass', () => {
     const guestToken = 'test-guest-token';
     const postFormPayload = { number: 123, array: [1, 2, 3] };
 
+    let authSpy: jest.SpyInstance;
     let client: SupersetClientClass;
     let appendChild: any;
     let removeChild: any;
@@ -622,6 +623,7 @@ describe('SupersetClientClass', () => {
 
     beforeEach(async () => {
       client = new SupersetClientClass({ protocol, host });
+      authSpy = jest.spyOn(SupersetClientClass.prototype, 'ensureAuth');
       await client.init();
       appendChild = jest.fn();
       removeChild = jest.fn();
@@ -658,6 +660,7 @@ describe('SupersetClientClass', () => {
 
       expect(appendChild.mock.calls).toHaveLength(1);
       expect(removeChild.mock.calls).toHaveLength(1);
+      expect(authSpy).toHaveBeenCalledTimes(1);
     });
 
     it('makes postForm request with guest token', async () => {
@@ -676,6 +679,7 @@ describe('SupersetClientClass', () => {
 
       expect(appendChild.mock.calls).toHaveLength(1);
       expect(removeChild.mock.calls).toHaveLength(1);
+      expect(authSpy).toHaveBeenCalledTimes(1);
     });
 
     it('makes postForm request with payload', async () => {
@@ -692,6 +696,7 @@ describe('SupersetClientClass', () => {
       expect(appendChild.mock.calls).toHaveLength(1);
       expect(removeChild.mock.calls).toHaveLength(1);
       expect(submit.mock.calls).toHaveLength(1);
+      expect(authSpy).toHaveBeenCalledTimes(1);
     });
 
     it('should do nothing when url is empty string', async () => {
@@ -700,6 +705,7 @@ describe('SupersetClientClass', () => {
       expect(createElement.mock.calls).toHaveLength(0);
       expect(appendChild.mock.calls).toHaveLength(0);
       expect(removeChild.mock.calls).toHaveLength(0);
+      expect(authSpy).toHaveBeenCalledTimes(0);
     });
   });
 });