chain async function

apache · Mar 4, 2022 · d87934c · d87934c
1 parent e045ce8
commit d87934c
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/superset-frontend/src/views/CRUD/hooks.ts b/superset-frontend/src/views/CRUD/hooks.ts
@@ -649,7 +649,7 @@ export function useDatabaseValidation() {
     null,
   );
   const getValidation = useCallback(
-    (database: Partial<DatabaseObject> | null, onCreate = false) => {
+    (database: Partial<DatabaseObject> | null, onCreate = false) =>
       SupersetClient.post({
         endpoint: '/api/v1/database/validate_parameters',
         body: JSON.stringify(database),
@@ -658,10 +658,10 @@ export function useDatabaseValidation() {
         .then(() => {
           setValidationErrors(null);
         })
+        // eslint-disable-next-line consistent-return
         .catch(e => {
-          setValidationErrors(null);
           if (typeof e.json === 'function') {
-            e.json().then(({ errors = [] }: JsonObject) => {
+            return e.json().then(({ errors = [] }: JsonObject) => {
               const parsedErrors = errors
                 .filter((error: { error_type: string }) => {
                   const skipValidationError = ![
@@ -749,12 +749,10 @@ export function useDatabaseValidation() {
                 );
               setValidationErrors(parsedErrors);
             });
-          } else {
-            // eslint-disable-next-line no-console
-            console.error(e);
           }
-        });
-    },
+          // eslint-disable-next-line no-console
+          console.error(e);
+        }),
     [setValidationErrors],
   );