Skip to content

Commit

Permalink
feat: allow adding pod labels (#18848)
Browse files Browse the repository at this point in the history
  • Loading branch information
vuongxuongminh committed Feb 23, 2022
1 parent cdd4fa5 commit dafc841
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 4 deletions.
2 changes: 1 addition & 1 deletion helm/superset/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ maintainers:
- name: craig-rueda
email: craig@craigrueda.com
url: https://github.com/craig-rueda
version: 0.5.9
version: 0.5.10
dependencies:
- name: postgresql
version: 10.2.0
Expand Down
3 changes: 3 additions & 0 deletions helm/superset/templates/deployment-beat.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ spec:
labels:
app: {{ template "superset.name" . }}-celerybeat
release: {{ .Release.Name }}
{{- if .Values.supersetCeleryBeat.podLabels }}
{{ toYaml .Values.supersetCeleryBeat.podLabels | nindent 8 }}
{{- end }}
spec:
securityContext:
runAsUser: {{ .Values.runAsUser }}
Expand Down
3 changes: 3 additions & 0 deletions helm/superset/templates/deployment-worker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ spec:
labels:
app: {{ template "superset.name" . }}-worker
release: {{ .Release.Name }}
{{- if .Values.supersetWorker.podLabels }}
{{ toYaml .Values.supersetWorker.podLabels | nindent 8 }}
{{- end }}
spec:
{{- if or (.Values.serviceAccount.create) (.Values.serviceAccountName) }}
serviceAccountName: {{ template "superset.serviceAccountName" . }}
Expand Down
3 changes: 3 additions & 0 deletions helm/superset/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ spec:
labels:
app: {{ template "superset.name" . }}
release: {{ .Release.Name }}
{{- if .Values.supersetNode.podLabels }}
{{ toYaml .Values.supersetNode.podLabels | nindent 8 }}
{{- end }}
spec:
{{- if or (.Values.serviceAccount.create) (.Values.serviceAccountName) }}
serviceAccountName: {{ template "superset.serviceAccountName" . }}
Expand Down
9 changes: 9 additions & 0 deletions helm/superset/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,9 @@
},
"podAnnotations": {
"$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.23.0/_definitions.json##/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta/properties/annotations"
},
"podLabels": {
"$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.23.0/_definitions.json##/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta/properties/labels"
}
},
"required": [
Expand Down Expand Up @@ -299,6 +302,9 @@
},
"podAnnotations": {
"$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.23.0/_definitions.json##/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta/properties/annotations"
},
"podLabels": {
"$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.23.0/_definitions.json##/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta/properties/labels"
}
},
"required": [
Expand Down Expand Up @@ -327,6 +333,9 @@
},
"podAnnotations": {
"$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.23.0/_definitions.json##/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta/properties/annotations"
},
"podLabels": {
"$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.23.0/_definitions.json##/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta/properties/labels"
}
},
"required": [
Expand Down
9 changes: 6 additions & 3 deletions helm/superset/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,8 @@ supersetNode:
deploymentAnnotations: {}
## Annotations to be added to supersetNode pods
podAnnotations: {}

## Labels to be added to supersetNode pods
podLabels: {}
##
## Superset worker configuration
supersetWorker:
Expand All @@ -269,7 +270,8 @@ supersetWorker:
deploymentAnnotations: {}
## Annotations to be added to supersetWorker pods
podAnnotations: {}

## Labels to be added to supersetWorker pods
podLabels: {}
##
## Superset beat configuration (to trigger scheduled jobs like reports)
supersetCeleryBeat:
Expand All @@ -292,7 +294,8 @@ supersetCeleryBeat:
deploymentAnnotations: {}
## Annotations to be added to supersetCeleryBeat pods
podAnnotations: {}

## Labels to be added to supersetCeleryBeat pods
podLabels: {}
##
## Init job configuration
init:
Expand Down

0 comments on commit dafc841

Please sign in to comment.