a default of an empty object and optional operator

apache · Aug 17, 2022 · dfb30fc · dfb30fc
1 parent 5920999
commit dfb30fc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/superset-frontend/src/SqlLab/App.jsx b/superset-frontend/src/SqlLab/App.jsx
@@ -95,7 +95,7 @@ const sqlLabPersistStateConfig = {
         ...initialState,
         ...persistedState,
         sqlLab: {
-          ...(persistedState && persistedState.sqlLab),
+          ...(persistedState?.sqlLab || {}),
           // Overwrite initialState over persistedState for sqlLab
           // since a logic in getInitialState overrides the value from persistedState
           ...initialState.sqlLab,

diff --git a/superset-frontend/src/SqlLab/actions/sqlLab.js b/superset-frontend/src/SqlLab/actions/sqlLab.js
@@ -383,7 +383,7 @@ export function runQueryFromSqlEditor(
     const qe = getUpToDateQuery(getState(), queryEditor, queryEditor.id);
     const query = {
       dbId: qe.dbId,
-      sql: qe.selectedText ? qe.selectedText : qe.sql,
+      sql: qe.selectedText || qe.sql,
       sqlEditorId: qe.id,
       tab: qe.name,
       schema: qe.schema,