fix(plugin-chart-table): metrics should be undefined (#1005)

apache · Nov 26, 2021 · e03c4ee · e03c4ee
1 parent a628251
commit e03c4ee
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/...t-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/buildQuery.ts b/...t-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/buildQuery.ts
@@ -59,10 +59,11 @@ const buildQuery: BuildQuery<TableChartFormData> = (formData: TableChartFormData
   }
 
   return buildQueryContext(formDataCopy, baseQueryObject => {
-    let { metrics = [], orderby = [] } = baseQueryObject;
+    let { metrics, orderby = [] } = baseQueryObject;
     let postProcessing: PostProcessingRule[] = [];
 
     if (queryMode === QueryMode.aggregate) {
+      metrics = metrics || [];
       // orverride orderby with timeseries metric when in aggregation mode
       if (sortByMetric) {
         orderby = [[sortByMetric, !orderDesc]];

diff --git a/...tend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/test/buildQuery.test.ts b/...tend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/test/buildQuery.test.ts
@@ -46,6 +46,18 @@ describe('plugin-chart-table', () => {
       ]);
     });
 
+    it('should not add metrics in raw records mode', () => {
+      const query = buildQuery({
+        ...basicFormData,
+        query_mode: QueryMode.raw,
+        columns: ['a'],
+        metrics: ['aaa', 'aaa'],
+        percent_metrics: ['bbb', 'bbb'],
+      }).queries[0];
+      expect(query.metrics).toBeUndefined();
+      expect(query.post_processing).toEqual([]);
+    });
+
     it('should not add post-processing when there is no percent metric', () => {
       const query = buildQuery({
         ...basicFormData,
@@ -65,7 +77,7 @@ describe('plugin-chart-table', () => {
         columns: ['rawcol'],
         percent_metrics: ['ccc'],
       }).queries[0];
-      expect(query.metrics).toEqual([]);
+      expect(query.metrics).toBeUndefined();
       expect(query.columns).toEqual(['rawcol']);
       expect(query.post_processing).toEqual([]);
     });