Apply suggestions from code review

Co-authored-by: Lily Kuang <lily@preset.io>
apache · Jan 25, 2022 · e3dc5ee · e3dc5ee
1 parent 8fb08b1
commit e3dc5ee
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/superset-frontend/src/embedded/index.tsx b/superset-frontend/src/embedded/index.tsx
@@ -34,7 +34,7 @@ const LazyDashboardPage = lazy(
 
 const EmbeddedApp = () => (
   <Router>
-    <Route path="/superset/dashboard/:idOrSlug/embedded">
+    <Route path="/dashboard/:idOrSlug/embedded">
       <Suspense fallback={<Loading />}>
         <RootContextProviders>
           <ErrorBoundary>

diff --git a/superset/config.py b/superset/config.py
@@ -405,7 +405,7 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
     # a custom security config could potentially give access to setting filters on
     # tables that users do not have access to.
     "ROW_LEVEL_SECURITY": True,
-    "EMBEDDED_SUPERSET": False,  # This requires that the public role be available
+    "EMBEDDED_SUPERSET": False,
     # Enables Alerts and reports new implementation
     "ALERT_REPORTS": False,
     # Enable experimental feature to search for other dashboards

diff --git a/superset/security/guest_token.py b/superset/security/guest_token.py
@@ -71,7 +71,7 @@ def is_authenticated(self) -> bool:
     def is_anonymous(self) -> bool:
         """
         This is set to false because lots of code assumes that
-        role = Public if user.is_anonymous == false.
+        if user.is_anonymous, then role = Public
         But guest users need to have their own role independent of Public.
         """
         return False