fix: Remove positions from json_metadata (#17766)

* Remove positions from json_metadata * Update superset-frontend/src/dashboard/components/PropertiesModal/index.tsx Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * Indent Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> (cherry picked from commit 274fb37)
apache · Dec 20, 2021 · f4661d6 · f4661d6
1 parent 398a01f
commit f4661d6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/superset-frontend/src/dashboard/components/PropertiesModal/index.tsx b/superset-frontend/src/dashboard/components/PropertiesModal/index.tsx
@@ -161,10 +161,15 @@ const PropertiesModal = ({
 
       form.setFieldsValue(dashboardInfo);
       setDashboardInfo(dashboardInfo);
-      setJsonMetadata(metadata ? jsonStringify(metadata) : '');
       setOwners(owners);
       setRoles(roles);
       setColorScheme(metadata.color_scheme);
+
+      // temporary fix to remove positions from dashboards' metadata
+      if (metadata?.positions) {
+        delete metadata.positions;
+      }
+      setJsonMetadata(metadata ? jsonStringify(metadata) : '');
     },
     [form],
   );

diff --git a/superset/dashboards/dao.py b/superset/dashboards/dao.py
@@ -239,6 +239,9 @@ def set_dash_metadata(  # pylint: disable=too-many-locals
             }
             md["default_filters"] = json.dumps(applicable_filters)
 
+            # positions have its own column, no need to store it in metadata
+            md.pop("positions", None)
+
         # The css and dashboard_title properties are not part of the metadata
         # TODO (geido): remove by refactoring/deprecating save_dash endpoint
         if data.get("css") is not None: