[core] support empty CSRF token (#7)

* [core][deps] remove unused deps

* [core][test] add test for response.ok=false

* [core] support csrf_token=''

* [core][tests] move mock to sole function that uses it

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/package.json

@@ -46,7 +46,6 @@
   },
   "dependencies": {
     "babel-runtime": "^6.26.0",
-    "url-search-params-polyfill": "^4.0.1",
     "whatwg-fetch": "^2.0.4"
   },
   "beemo": {

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/src/SupersetClient.js

@@ -31,6 +31,8 @@ class SupersetClient {
   }
 
   getCSRFToken() {
+    this.csrfToken = null;
+
     // If we can request this resource successfully, it means that the user has
     // authenticated. If not we throw an error prompting to authenticate.
     this.csrfPromise = callApi({
@@ -46,10 +48,10 @@ class SupersetClient {
       if (response.json) {
         this.csrfToken = response.json.csrf_token;
         this.headers = { ...this.headers, 'X-CSRFToken': this.csrfToken };
-        this.didAuthSuccessfully = !!this.csrfToken;
+        this.didAuthSuccessfully = this.csrfToken !== null && this.csrfPromise !== undefined;
       }
 
-      if (!this.csrfToken) {
+      if (!this.didAuthSuccessfully) {
         return Promise.reject({ error: 'Failed to fetch CSRF token' });
       }
 

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/src/callApi/callApi.js

@@ -1,5 +1,4 @@
 import 'whatwg-fetch';
-import 'url-search-params-polyfill';
 
 const DEFAULT_HEADERS = null;
 

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/src/callApi/parseResponse.js

@@ -11,12 +11,7 @@ export default function parseResponse(apiPromise, parseMethod = 'json') {
   return apiPromise
     .then(response => {
       if (!response.ok) {
-        return Promise.reject({
-          error: response.error || 'An error occurred',
-          response,
-          status: response.status,
-          statusText: response.statusText,
-        });
+        return Promise.reject(response);
       }
 
       return response;

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/test/SupersetClient.test.js

@@ -7,7 +7,7 @@ import { LOGIN_GLOB } from './fixtures/constants';
 
 describe('SupersetClient', () => {
   beforeAll(() => {
-    fetchMock.get(LOGIN_GLOB, { csrf_token: '1234' });
+    fetchMock.get(LOGIN_GLOB, { csrf_token: '' });
   });
 
   afterAll(fetchMock.restore);

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/test/callApi/callApi.test.js

@@ -14,15 +14,12 @@ describe('callApi()', () => {
 
   const mockGetUrl = '/mock/get/url';
   const mockPostUrl = '/mock/post/url';
-  const mockErrorUrl = '/mock/error/url';
 
   const mockGetPayload = { get: 'payload' };
   const mockPostPayload = { post: 'payload' };
-  const mockErrorPayload = { status: 500, statusText: 'Internal error' };
 
   fetchMock.get(mockGetUrl, mockGetPayload);
   fetchMock.post(mockPostUrl, mockPostPayload);
-  fetchMock.get(mockErrorUrl, () => Promise.reject(mockErrorPayload));
 
   afterEach(fetchMock.reset);
 
@@ -145,6 +142,10 @@ describe('callApi()', () => {
   });
 
   it('rejects if the request throws', () => {
+    const mockErrorUrl = '/mock/error/url';
+    const mockErrorPayload = { status: 500, statusText: 'Internal error' };
+    fetchMock.get(mockErrorUrl, () => Promise.reject(mockErrorPayload));
+
     expect.assertions(3);
 
     return callApi({ url: mockErrorUrl, method: 'GET' })

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/test/callApi/parseResponse.test.js

@@ -101,4 +101,20 @@ describe('parseResponse()', () => {
       return Promise.resolve();
     });
   });
+
+  it('rejects if request.ok=false', () => {
+    const mockNotOkayUrl = '/mock/notokay/url';
+    fetchMock.get(mockNotOkayUrl, 404); // 404s result in not response.ok=false
+
+    expect.assertions(3);
+    const apiPromise = callApi({ url: mockNotOkayUrl, method: 'GET' });
+
+    return parseResponse(apiPromise)
+      .then(throwIfCalled)
+      .catch(response => {
+        expect(fetchMock.calls(mockNotOkayUrl)).toHaveLength(1);
+        expect(response.ok).toBe(false);
+        expect(response.status).toBe(404);
+      });
+  });
 });