fix: 🐛 Fixed type definition for chart plugin (#123)

* fix: 🐛 Fixed typ definiton for chart plugin

This PR is to fix the type definiton for transformProps and LoadData.

* fix: 🐛 Type compatibility

Change the output of preTransformProps to ChartProps

* fix: 🐛 Fixed Test

Fixed the test according to the changes:

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/index.ts

@@ -25,3 +25,4 @@ export * from './types/Annotation';
 export * from './types/Datasource';
 export * from './types/ChartFormData';
 export * from './types/Query';
+export * from './types/Metric';

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/models/ChartPlugin.ts

@@ -12,7 +12,7 @@ const IDENTITY = (x: any) => x;
 
 export type PromiseOrValue<T> = Promise<T> | T;
 export type PromiseOrValueLoader<T> = () => PromiseOrValue<T>;
-export type ChartType = ComponentType | FunctionComponent;
+export type ChartType = ComponentType<any> | FunctionComponent<any>;
 type ValueOrModuleWithValue<T> = T | { default: T };
 
 interface ChartPluginConfig<T extends ChartFormData> {

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/types/Query.ts

@@ -38,8 +38,8 @@ export interface PlainProps {
 
 type TransformFunction<Input = PlainProps, Output = PlainProps> = (x: Input) => Output;
 
-export type PreTransformProps = TransformFunction<ChartProps>;
-export type TransformProps = TransformFunction;
+export type PreTransformProps = TransformFunction<ChartProps, ChartProps>;
+export type TransformProps = TransformFunction<ChartProps>;
 export type PostTransformProps = TransformFunction;
 
 export type BuildQueryFunction<T extends ChartFormData> = (formData: T) => QueryContext;

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/test/components/SuperChart.test.tsx

@@ -110,8 +110,15 @@ describe('SuperChart', () => {
       }, 0);
     });
     it('uses preTransformProps when specified', done => {
+      const chartPropsWithPayload = new ChartProps({
+        payload: { character: 'hulk' },
+      });
       const wrapper = shallow(
-        <SuperChart chartType="my-chart" preTransformProps={() => ({ character: 'hulk' })} />,
+        <SuperChart
+          chartType="my-chart"
+          preTransformProps={() => chartPropsWithPayload}
+          overrideTransformProps={props => props.payload}
+        />,
       );
       setTimeout(() => {
         expect(