Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering Visualizations for customized engines #1035

Closed
ShengyaoQian opened this issue Aug 29, 2016 · 4 comments
Closed

Rendering Visualizations for customized engines #1035

ShengyaoQian opened this issue Aug 29, 2016 · 4 comments

Comments

@ShengyaoQian
Copy link

We've added a third datasource to caravel. The code for this change is completely separated. But when it comes to rendering the UI part, I have to add the datasource id field in the Slice model in models.py and in the explore function in views.py so it can acknowledge this new datasource. And load viz for it. Can you make this more generic so when we add a new source, the views part can automatically recognize it. In this way we can add our customized part separately and still use your package so we don't need to maintain our own fork.

@ShengyaoQian
Copy link
Author

@joshwalters

@xrmx
Copy link
Contributor

xrmx commented Aug 30, 2016

@ShengyaoQian sorry but i haven't understood what your issue is. If you need some changes feel free to send a pull request so it's easier to understand what you want to do.

@xrmx xrmx added the question label Aug 30, 2016
@ShengyaoQian
Copy link
Author

#1078

@mistercrunch
Copy link
Member

Notice: this issue has been closed because it has been inactive for 591 days. Feel free to comment and request for this issue to be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants