-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering Visualizations for customized engines #1035
Comments
@ShengyaoQian sorry but i haven't understood what your issue is. If you need some changes feel free to send a pull request so it's easier to understand what you want to do. |
Notice: this issue has been closed because it has been inactive for 591 days. Feel free to comment and request for this issue to be reopened. |
This was referenced Apr 30, 2021
[Snyk] Upgrade @superset-ui/plugin-chart-table from 0.15.10 to 0.17.30
edmooney/incubator-superset#3
Open
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We've added a third datasource to caravel. The code for this change is completely separated. But when it comes to rendering the UI part, I have to add the datasource id field in the Slice model in models.py and in the explore function in views.py so it can acknowledge this new datasource. And load viz for it. Can you make this more generic so when we add a new source, the views part can automatically recognize it. In this way we can add our customized part separately and still use your package so we don't need to maintain our own fork.
The text was updated successfully, but these errors were encountered: