Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double escaping of dttm expressions #1103

Merged
merged 1 commit into from
Sep 17, 2016

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Sep 13, 2016

If ddtm_expr is an expression with special characters then timestamp_grain escapes
the special characters already escaped.

Solution discussed with sqlalchemy upstream:
https://bitbucket.org/zzzeek/sqlalchemy/issues/3737/literal_column-given-a-specific-sql

Fix #617

If ddtm_expr is an expression with special characters then timestamp_grain escapes
the special characters already escaped.

Solution discussed with sqlalchemy upstream:
https://bitbucket.org/zzzeek/sqlalchemy/issues/3737/literal_column-given-a-specific-sql

Fix apache#617
@mistercrunch
Copy link
Member

LGTM

@mistercrunch mistercrunch merged commit 69d37d8 into apache:master Sep 17, 2016
dennisobrien pushed a commit to dennisobrien/caravel that referenced this pull request Sep 19, 2016
If ddtm_expr is an expression with special characters then timestamp_grain escapes
the special characters already escaped.

Solution discussed with sqlalchemy upstream:
https://bitbucket.org/zzzeek/sqlalchemy/issues/3737/literal_column-given-a-specific-sql

Fix apache#617
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
)

* fix(plugin-chart-echarts): enhancements for the treemap

* fix(plugin-chart-echarts): use '▸' to replace '/', filter empty string
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
)

* fix(plugin-chart-echarts): enhancements for the treemap

* fix(plugin-chart-echarts): use '▸' to replace '/', filter empty string
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
)

* fix(plugin-chart-echarts): enhancements for the treemap

* fix(plugin-chart-echarts): use '▸' to replace '/', filter empty string
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
)

* fix(plugin-chart-echarts): enhancements for the treemap

* fix(plugin-chart-echarts): use '▸' to replace '/', filter empty string
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expression in table columns is converted to literal column twice
3 participants