1. literal_column currently adds extra escape % for existing item, th… #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is now will be replaced with a custom compile method to remove percentage. 2. Refers to caravel issue: #617 and applied a solution discussed with sqlalchemy contributor: https://bitbucket.org/zzzeek/sqlalchemy/issues/3737/literal_column-given-a-specific-sql. 3. The actual milestone feature of literal_column of 1.2 will be early next year 2017.
… and also added NotImplmenetedError catch
…ethod name from _remove_percents to _ to avoid w0612 pylint method name
|
Patch looks good to me. |
|
Squashed commits and rebased here: |
xrmx
pushed a commit
to xrmx/superset
that referenced
this pull request
Sep 13, 2016
If ddtm_expr is an expression with special characters then timestamp_grain escapes the special characters already escaped. Solution discussed with sqlalchemy upstream: https://bitbucket.org/zzzeek/sqlalchemy/issues/3737/literal_column-given-a-specific-sql Fix apache#617
mistercrunch
pushed a commit
that referenced
this pull request
Sep 17, 2016
If ddtm_expr is an expression with special characters then timestamp_grain escapes the special characters already escaped. Solution discussed with sqlalchemy upstream: https://bitbucket.org/zzzeek/sqlalchemy/issues/3737/literal_column-given-a-specific-sql Fix #617
|
Superseded by #1103, sorry for the missing authorship 😓 |
|
Oh, so i wait no authorship? 😟 |
dennisobrien
pushed a commit
to dennisobrien/caravel
that referenced
this pull request
Sep 19, 2016
If ddtm_expr is an expression with special characters then timestamp_grain escapes the special characters already escaped. Solution discussed with sqlalchemy upstream: https://bitbucket.org/zzzeek/sqlalchemy/issues/3737/literal_column-given-a-specific-sql Fix apache#617
xrmx
added a commit
to xrmx/superset
that referenced
this pull request
Oct 5, 2016
As he's the author of the patch
mistercrunch
pushed a commit
that referenced
this pull request
Oct 5, 2016
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
1. move translation, connection, query to core (apache#729) 2. update encodable to remove formatter inter-dependency (apache#744) 3. move number-format and time-format to core (apache#730) 4. move superset-ui/dimension to core (apache#732) 5. move superset-ui/color to core (apache#755) 6. move superset-ui/style to core (apache#756) 7. move superset-ui/validator to core (apache#757) 8. move superset-ui/chart-composition to core (apache#759) 9. move superset-ui/chart to core (apache#760)
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
1. move translation, connection, query to core (apache#729) 2. update encodable to remove formatter inter-dependency (apache#744) 3. move number-format and time-format to core (apache#730) 4. move superset-ui/dimension to core (apache#732) 5. move superset-ui/color to core (apache#755) 6. move superset-ui/style to core (apache#756) 7. move superset-ui/validator to core (apache#757) 8. move superset-ui/chart-composition to core (apache#759) 9. move superset-ui/chart to core (apache#760)
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
1. move translation, connection, query to core (apache#729) 2. update encodable to remove formatter inter-dependency (apache#744) 3. move number-format and time-format to core (apache#730) 4. move superset-ui/dimension to core (apache#732) 5. move superset-ui/color to core (apache#755) 6. move superset-ui/style to core (apache#756) 7. move superset-ui/validator to core (apache#757) 8. move superset-ui/chart-composition to core (apache#759) 9. move superset-ui/chart to core (apache#760)
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
1. move translation, connection, query to core (apache#729) 2. update encodable to remove formatter inter-dependency (apache#744) 3. move number-format and time-format to core (apache#730) 4. move superset-ui/dimension to core (apache#732) 5. move superset-ui/color to core (apache#755) 6. move superset-ui/style to core (apache#756) 7. move superset-ui/validator to core (apache#757) 8. move superset-ui/chart-composition to core (apache#759) 9. move superset-ui/chart to core (apache#760)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #617
%, this now will be replaced with a custom compile method to remove percentage.