Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time series bar chart broken #1114

Closed
xrmx opened this issue Sep 15, 2016 · 4 comments
Closed

time series bar chart broken #1114

xrmx opened this issue Sep 15, 2016 · 4 comments
Assignees
@vera-liu
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@xrmx
Copy link
Contributor

xrmx commented Sep 15, 2016 •
edited

On e895807 firefox spit this but quite not useful with packed libs:

value not expected NaN during interpreration of attribute y2. explore.entry.js:7:7367
value not expected NaN during interpreration of attribute y. explore.entry.js:7:7367
value not expected NaN during interpreration of attribute height.  explore.entry.js:11:16027

The legend and the x axis label are displayed but nothing else.

All other time series visualization works fine with the same data.
@xrmx xrmx added the !deprecated-label:bug Deprecated label - Use #bug instead label Sep 15, 2016
@xrmx
Copy link
Contributor Author

xrmx commented Sep 15, 2016

So this is a regression from 9ae231a since if i change the bottom margin to everything but "auto" it works fine. cc @vera-liu

@xrmx
Copy link
Contributor Author

xrmx commented Sep 16, 2016

2132f67 does not help with the issue

@vera-liu vera-liu self-assigned this Sep 16, 2016
@vera-liu
Copy link
Contributor

Sorry going back and forth, this should fix it now: #1124

@xrmx
Copy link
Contributor Author

xrmx commented Sep 17, 2016

@vera-liu thank you very much! Will test on monday but it looks like it will fix it.

@xrmx xrmx closed this as completed Sep 17, 2016
@snyk-bot snyk-bot mentioned this issue Jul 7, 2021
Closed
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@kgabryje @zhaoyongjie
feat(core): remove defaults for time range filter and Metrics (apache…
6a319dd 
…#1114)

* feat(core): remove defaults for time range filter and Metrics

* Display errors on all 3 controls

* Fix for raw mode

* Refactor duplicated code
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@kgabryje @zhaoyongjie
feat(core): remove defaults for time range filter and Metrics (apache…
c8cf0fe 
…#1114)

* feat(core): remove defaults for time range filter and Metrics

* Display errors on all 3 controls

* Fix for raw mode

* Refactor duplicated code
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@kgabryje @zhaoyongjie
feat(core): remove defaults for time range filter and Metrics (apache…
f37d199 
…#1114)

* feat(core): remove defaults for time range filter and Metrics

* Display errors on all 3 controls

* Fix for raw mode

* Refactor duplicated code
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@kgabryje @zhaoyongjie
feat(core): remove defaults for time range filter and Metrics (apache…
1a4e3e8 
…#1114)

* feat(core): remove defaults for time range filter and Metrics

* Display errors on all 3 controls

* Fix for raw mode

* Refactor duplicated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vera-liu vera-liu

Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xrmx @vera-liu