[security] allowing to set static headers as configuration #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@williaster does that break your integration? |
mistercrunch
force-pushed
the
clickjack
branch
from
d1a5839
to
6e20b47
Compare
mistercrunch
changed the title
ascott
reviewed
Sep 20, 2016
| # static http headers to be served by your Caravel server. | ||
| # The following example prevents iFrame from other domains | ||
| # and "clickjacking" as a result | ||
| # HTTP_HEADERS = {'X-Frame-Options': 'SAMEORIGIN'} |
There was a problem hiding this comment.
isn't this the one we want to uncomment?
There was a problem hiding this comment.
It's there as an example, I don't want to set headers on behalf of others. People override this configuration by setting up a caravel_config module in their PYTHONPATH (for us it's doen in chef), where I have another PR.
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* fix(plugin-chart-echarts): sanitize series from html tags * use echarts html encoder
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* fix(plugin-chart-echarts): sanitize series from html tags * use echarts html encoder
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* fix(plugin-chart-echarts): sanitize series from html tags * use echarts html encoder
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* fix(plugin-chart-echarts): sanitize series from html tags * use echarts html encoder
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.