-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[security] allowing to set static headers as configuration #1126
Conversation
@williaster does that break your integration? |
d1a5839
to
6e20b47
Compare
# static http headers to be served by your Caravel server. | ||
# The following example prevents iFrame from other domains | ||
# and "clickjacking" as a result | ||
# HTTP_HEADERS = {'X-Frame-Options': 'SAMEORIGIN'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this the one we want to uncomment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's there as an example, I don't want to set headers on behalf of others. People override this configuration by setting up a caravel_config
module in their PYTHONPATH (for us it's doen in chef), where I have another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah gotcha! 🆗 🎉
* fix(plugin-chart-echarts): sanitize series from html tags * use echarts html encoder
* fix(plugin-chart-echarts): sanitize series from html tags * use echarts html encoder
* fix(plugin-chart-echarts): sanitize series from html tags * use echarts html encoder
* fix(plugin-chart-echarts): sanitize series from html tags * use echarts html encoder
No description provided.