Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting row limit in SQL Lab disables warning #1148

Closed
maver1ck opened this issue Sep 20, 2016 · 0 comments · Fixed by #1230
Closed

Setting row limit in SQL Lab disables warning #1148

maver1ck opened this issue Sep 20, 2016 · 0 comments · Fixed by #1230
Labels
!deprecated-label:bug Deprecated label - Use #bug instead sqllab Namespace | Anything related to the SQL Lab

Comments

@maver1ck
Copy link
Contributor

Hi,
I found following bug.
I set in caravel_config.py row limit for SQL Lab:

SQL_MAX_ROW = 100

This disables warning because in JS limit is constant and equal 1000.
https://github.com/airbnb/caravel/blob/e8088d5c9a522db5e0e165988fba47893337fd5b/caravel/assets/javascripts/SqlLab/components/SqlEditor.jsx#L196
@xrmx xrmx added the sqllab Namespace | Anything related to the SQL Lab label Sep 20, 2016
@mistercrunch mistercrunch added the !deprecated-label:bug Deprecated label - Use #bug instead label Sep 22, 2016
@bkyryliuk bkyryliuk self-assigned this Sep 30, 2016
@bkyryliuk bkyryliuk mentioned this issue Sep 30, 2016
Merged
@snyk-bot snyk-bot mentioned this issue Jul 7, 2021
Closed
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@zhaoyongjie
feat: expose form_data to datasourceControl (apache#1148)
f05dd7f
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@zhaoyongjie
feat: expose form_data to datasourceControl (apache#1148)
3a5798d
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@zhaoyongjie
feat: expose form_data to datasourceControl (apache#1148)
290b568
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@zhaoyongjie
feat: expose form_data to datasourceControl (apache#1148)
6b4480b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
!deprecated-label:bug Deprecated label - Use #bug instead sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SQLLab] user server for the query limit check.
4 participants
@xrmx @mistercrunch @maver1ck @bkyryliuk