Flask View redirects on save are broken

[bkyryliuk]

Caravel has a weird redirection after saving the model in caravel, for instance when I save https://caravel_host/tablemodelview/edit/1647 - it redirects me to the random model lists like database, slice, etc...

[bkyryliuk]

Looks like @mistercrunch was on top of it:
dpgaspar/Flask-AppBuilder#318

[bkyryliuk]

While debugging I was able to get:

from flask import session
print(session['page_history'])
[u'http://localhost:8081/tablemodelview/list/', u'http://localhost:8081/dashboardmodelview/list/', u'http://localhost:8081/slicemodelview/list/', u'http://localhost:8081/tablemodelview/list/', u'http://localhost:8081/dashboardmodelview/edit/99']
session['page_history']

FAB uses prev url for the redirect:
https://github.com/dpgaspar/Flask-AppBuilder/blob/af095ac4094d068fa2dd467bd01fa8b95d697fc1/flask_appbuilder/baseviews.py#L193

Once the history didn't have any http://localhost:8081/dashboardmodelview/edit/XX

[u'http://localhost:8081/tablemodelview/list/', u'http://localhost:8081/dashboardmodelview/list/', u'http://localhost:8081/slicemodelview/list/', u'http://localhost:8081/tablemodelview/list/', u'http://localhost:8081/dashboardmodelview/list/']

[bkyryliuk]

Looks like session history works across tabs:

[u'http://localhost:8081/slicemodelview/list/', u'http://localhost:8081/dashboardmodelview/list/', u'http://localhost:8081/dashboardmodelview/edit/99', u'http://localhost:8081/slicemodelview/list/', u'http://localhost:8081/slicemodelview/edit/119']

I opened the dashboardmodelview/list and then dashboardmodelview/edit/XX on one tab and then opened slicemodelview/list and slicemodelview/edit/XX on another and moved back to the tab with dashboardmodelview/edit.
Saving the dashboardmodelview/edit. redirects to the slicemodelview/list

[bkyryliuk]

PR: dpgaspar/Flask-AppBuilder#381

[bkyryliuk]

blocked on the flask review