Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite month grain is calculating wrong #1234

Closed
htruongaff opened this issue Oct 3, 2016 · 0 comments · Fixed by #2380
Closed

sqlite month grain is calculating wrong #1234

htruongaff opened this issue Oct 3, 2016 · 0 comments · Fixed by #2380
Labels
airbnb Airbnb related change:backend Requires changing the backend !deprecated-label:bug Deprecated label - Use #bug instead

Comments

@htruongaff
Copy link

I noticed the sqlite month grain is removing Day of the Month when it should be removing (day of the month -1).

  'sqlite': (
                Grain('Time Column', _('Time Column'), '{col}'),
                Grain('day', _('day'), 'DATE({col})'),
                Grain("week", _('week'),
                      "DATE({col}, -strftime('%w', {col}) || ' days')"),
                Grain("month", _('month'),
                      "DATE({col}, -strftime('%d', {col}) || ' days')"),
            ),

should be as below otherwise month grouping gives you the prior month.

                Grain("month", _('month'),
                      "DATE({col}, -(strftime('%d', {col}) -1) || ' days')"),
            ),
@bkyryliuk bkyryliuk added !deprecated-label:bug Deprecated label - Use #bug instead airbnb Airbnb related change:backend Requires changing the backend labels Oct 3, 2016
@bkyryliuk bkyryliuk self-assigned this Oct 3, 2016
@bkyryliuk bkyryliuk added this to the Los Cabos Sprint 2016-10-03 milestone Oct 3, 2016
@dpgaspar dpgaspar mentioned this issue Jan 23, 2020
12 tasks
romaine-murray added a commit to Aeontsolutions/superset that referenced this issue Nov 26, 2023
The Jacie Chatbot link is added to the RightMenu component when the user
is not anonymous. This allows users to easily access the chatbot for
assistance. This change enhances user experience and provides a
convenient way to interact with the chatbot support system.

Issue apache#1234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airbnb Airbnb related change:backend Requires changing the backend !deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants