Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong redirect link in CONTRIBUTING.md #12717

Closed
a5net opened this issue Jan 24, 2021 · 2 comments
Closed

Wrong redirect link in CONTRIBUTING.md #12717

a5net opened this issue Jan 24, 2021 · 2 comments
Labels
doc:developer Developer documentation

Comments

@a5net
Copy link
Contributor

a5net commented Jan 24, 2021

Description

CONTRIBUTING.md includes a link to OS dependencies that need to be installed before other dependencies. But the link is outdated.

Expected results

Should redirect to
https://superset.apache.org/docs/installation/installing-superset-from-scratch#os-dependencies

Actual results

Instead redirects to installation with Docker Compose:
https://superset.apache.org/docs/installation/installing-superset-using-docker-compose

Additional Context

I verified that it is the right link by checking the previous version of the documentation website. The content is the same.
https://web.archive.org/web/20181103115231/https://superset.incubator.apache.org/installation.html#os-dependencies

@junlincc junlincc added the doc:developer Developer documentation label Jan 24, 2021
@junlincc
Copy link
Member

thanks for reporting and the fix! @ayanginet 🙏

@srinify
Copy link
Contributor

srinify commented Jan 26, 2021

Thank you for fixing! @ayanginet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc:developer Developer documentation
Projects
None yet
Development

No branches or pull requests

3 participants