Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Query url shortener #1310

Closed
vera-liu opened this issue Oct 10, 2016 · 5 comments
Closed

Copy Query url shortener #1310

vera-liu opened this issue Oct 10, 2016 · 5 comments
Assignees
@vera-liu
Labels
sqllab Namespace | Anything related to the SQL Lab
Milestone
Ipswich Sprint 20...

Comments

@vera-liu
Copy link
Contributor

vera-liu commented Oct 10, 2016 •
edited

Use a url shortener for sharing query functionality, without exposing userId, dbId and sql query in url.
related: #1052
@vera-liu vera-liu added the sqllab Namespace | Anything related to the SQL Lab label Oct 10, 2016
@vera-liu vera-liu self-assigned this Oct 10, 2016
@vera-liu vera-liu mentioned this issue Oct 10, 2016
Closed
@bkyryliuk
Copy link
Member

I meant a bit different thing. For the external product to be able to open a query in SQL Lab it would be challenging to know the user_id and database_id:

  • User ID is already known in state, that should not be parameter, and when different user open's the query up - it should be tied to his account.
  • Database name should be sufficient for us to look up the database id
  • Schema may be needed as user can create the query using database and schema.

@vera-liu
Copy link
Contributor Author

@bogdan Ahh gotcha, created another issue #1328 will work on it

@vera-liu
Copy link
Contributor Author

@bkyryliuk Actually after looking at this, userID is not part of the copy query link, and schema is already in the link, so the only thing left to do here is changing dbId to dbname

@bkyryliuk
Copy link
Member

@vera-liu - great news !

@vera-liu
Copy link
Contributor Author

#1314

@ascott ascott added this to the Ipswich Sprint 2016-11-11 milestone Oct 24, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@geido @zhaoyongjie
fix: Make the scrollbar appear inside the table (apache#1310)
43e4d01 
* Scroll container

* Add X scroll

* Remove widht min-content
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@geido @zhaoyongjie
fix: Make the scrollbar appear inside the table (apache#1310)
81ff20b 
* Scroll container

* Add X scroll

* Remove widht min-content
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@geido @zhaoyongjie
fix: Make the scrollbar appear inside the table (apache#1310)
7d083b4 
* Scroll container

* Add X scroll

* Remove widht min-content
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@geido @zhaoyongjie
fix: Make the scrollbar appear inside the table (apache#1310)
fdcc079 
* Scroll container

* Add X scroll

* Remove widht min-content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vera-liu vera-liu

Labels
sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Milestone
Ipswich Sprint 2016-11-11
Development

No branches or pull requests
3 participants
@ascott @bkyryliuk @vera-liu