Specify the metric to order by for Series Limit #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
specify_order_limit
branch
2 times, most recently
from
842b1a7
to
bc43be3
Compare
|
👍 Thanks a lot Maxime. Your very quick help was well above my expectation :) |
NeginNejati
reviewed
Oct 14, 2016
| subq = subq.order_by(desc(main_metric_expr)) | ||
| ob = main_metric_expr | ||
| if timeseries_limit_metric_expr is not None: | ||
| ob = timeseries_limit_metric_expr |
| timeseries_limit_metric_expr = None | ||
| if timeseries_limit_metric: | ||
| timeseries_limit_metric_expr = \ | ||
| timeseries_limit_metric.sqla_col |
There was a problem hiding this comment.
too long for PEP8's 80 char limit
| @@ -1689,6 +1699,7 @@ def query( # druid | |||
| filter=None, # noqa | |||
| is_timeseries=True, | |||
| timeseries_limit=None, | |||
| timeseries_limit_metric=None, | |||
There was a problem hiding this comment.
umm why do we need to override this here?
| timeseries_limit_metric = metrics_dict.get(timeseries_limit_metric) | ||
| timeseries_limit_metric_expr = None | ||
| if timeseries_limit_metric: | ||
| timeseries_limit_metric_expr = \ |
There was a problem hiding this comment.
just curious, what's \ at the end? (am new to python)
There was a problem hiding this comment.
python's way of terminating a line on another line
mistercrunch
force-pushed
the
specify_order_limit
branch
from
bc43be3
to
472bdf7
Compare
neevany
pushed a commit
to Kieraya/caravel
that referenced
this pull request
Oct 24, 2016
|
@mistercrunch Hi, do you have any plan on enabling metrics ordering? For example, I want to show the first metric on the left in the visualization, but it is always the largest on the left. Just asking... I know you have to prioritize everything. Thanks a lot! |
|
How to specify the order by on metrics (computed columns) ? |
12 tasks
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…pache#1351) * feat: add x and y label support for timeseries fix apache#16512 * feat: change label to title * feat: add x/y title to 9 chats * refactor: move config to shared-control * refactor: add chartTitle section config in custom tab * refactor: refactor param names * lint: code lint * refactor: refactor code * lint: lint code * feat: make ypostion clearable false * lint: code lint Co-authored-by: xuzhebin <maxhui2020@gmail.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…pache#1351) * feat: add x and y label support for timeseries fix apache#16512 * feat: change label to title * feat: add x/y title to 9 chats * refactor: move config to shared-control * refactor: add chartTitle section config in custom tab * refactor: refactor param names * lint: code lint * refactor: refactor code * lint: lint code * feat: make ypostion clearable false * lint: code lint Co-authored-by: xuzhebin <maxhui2020@gmail.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…pache#1351) * feat: add x and y label support for timeseries fix apache#16512 * feat: change label to title * feat: add x/y title to 9 chats * refactor: move config to shared-control * refactor: add chartTitle section config in custom tab * refactor: refactor param names * lint: code lint * refactor: refactor code * lint: lint code * feat: make ypostion clearable false * lint: code lint Co-authored-by: xuzhebin <maxhui2020@gmail.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…pache#1351) * feat: add x and y label support for timeseries fix apache#16512 * feat: change label to title * feat: add x/y title to 9 chats * refactor: move config to shared-control * refactor: add chartTitle section config in custom tab * refactor: refactor param names * lint: code lint * refactor: refactor code * lint: lint code * feat: make ypostion clearable false * lint: code lint Co-authored-by: xuzhebin <maxhui2020@gmail.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to be based on the first metric from the metric multi-choice, but there's the use case where you don't want to show the metric you are sorting by. It will still default to use the first metric if the new select is empty