Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[time_series][feature_parity] no options to add x-axis label in customize panel for new echarts time series #16512

Closed
jinghua-qa opened this issue Aug 30, 2021 · 3 comments
Closed

[time_series][feature_parity] no options to add x-axis label in customize panel for new echarts time series #16512

jinghua-qa opened this issue Aug 30, 2021 · 3 comments
Labels
preset:QA Preset QA team
Projects
Community Usability Bash! 🐛🐞🕷

Comments

@jinghua-qa
Copy link
Member

jinghua-qa commented Aug 30, 2021 •
edited
Loading

Some new charts do not have x-axis tile option in customize panel, can we add that?

no.x-axis.title.option.in.customize.mov
  • list of charts missing x-axis tile option:
  • time series line chart,
  • time series area chart,
  • time series bar chat,
  • time series scatter plot,
  • mix time series,
  • time series chart,
  • time series smooth line,
  • time series stepped line,
  • box plot

For the old charts, current filed name call 'x-axis label' and in new charts field, axis label is referred to the label on each point on the axis, maybe we should just rename those filed to be axis title?

old charts with field name 'x-axis label' or 'y-axis label' currently:

  • area chart,
  • bar chart ,
  • bubble chart,
  • histogram,
  • line chart,
  • time-series percent change,
  • time series period pivot
@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Aug 30, 2021
@junlincc junlincc changed the title [chart viz] no options to add x-axis tile in customize panel for new charts [time_series][feature_parity] no options to add x-axis tile in customize panel for new charts Aug 30, 2021
@junlincc junlincc changed the title [time_series][feature_parity] no options to add x-axis tile in customize panel for new charts [time_series][feature_parity] no options to add x-axis label in customize panel for new echarts time series Aug 30, 2021
@junlincc
Copy link
Member

@MaxHuiYYDS would you like to work on this one?

cc @stephenLYZ

@MaxHuiYYDS
Copy link
Contributor

@MaxHuiYYDS would you like to work on this one?

cc @stephenLYZ

OK, I will look at it

This was referenced Sep 6, 2021
Closed
Merged
@zhaoyongjie
Copy link
Member

fixed by apache-superset/superset-ui#1351
@junlincc @MaxHuiYYDS @jinghua-qa

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@MaxHuiYYDS @zhaoyongjie
feat(plugin-chart-echarts): add x and y label support for 9 charts (a…
75a432d 
…pache#1351)

* feat: add x and y label support for timeseries

fix apache#16512

* feat: change label to title

* feat: add x/y title to 9 chats

* refactor: move config to shared-control

* refactor: add chartTitle section config in custom tab

* refactor: refactor param names

* lint: code lint

* refactor: refactor code

* lint: lint code

* feat: make ypostion clearable false

* lint: code lint

Co-authored-by: xuzhebin <maxhui2020@gmail.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@MaxHuiYYDS @zhaoyongjie
feat(plugin-chart-echarts): add x and y label support for 9 charts (a…
df40ee1 
…pache#1351)

* feat: add x and y label support for timeseries

fix apache#16512

* feat: change label to title

* feat: add x/y title to 9 chats

* refactor: move config to shared-control

* refactor: add chartTitle section config in custom tab

* refactor: refactor param names

* lint: code lint

* refactor: refactor code

* lint: lint code

* feat: make ypostion clearable false

* lint: code lint

Co-authored-by: xuzhebin <maxhui2020@gmail.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@MaxHuiYYDS @zhaoyongjie
feat(plugin-chart-echarts): add x and y label support for 9 charts (a…
c6c84cf 
…pache#1351)

* feat: add x and y label support for timeseries

fix apache#16512

* feat: change label to title

* feat: add x/y title to 9 chats

* refactor: move config to shared-control

* refactor: add chartTitle section config in custom tab

* refactor: refactor param names

* lint: code lint

* refactor: refactor code

* lint: lint code

* feat: make ypostion clearable false

* lint: code lint

Co-authored-by: xuzhebin <maxhui2020@gmail.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@MaxHuiYYDS @zhaoyongjie
feat(plugin-chart-echarts): add x and y label support for 9 charts (a…
e149c53 
…pache#1351)

* feat: add x and y label support for timeseries

fix apache#16512

* feat: change label to title

* feat: add x/y title to 9 chats

* refactor: move config to shared-control

* refactor: add chartTitle section config in custom tab

* refactor: refactor param names

* lint: code lint

* refactor: refactor code

* lint: lint code

* feat: make ypostion clearable false

* lint: code lint

Co-authored-by: xuzhebin <maxhui2020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
preset:QA Preset QA team
Projects
No open projects
Community Usability Bash! 🐛🐞🕷
Unassigned
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zhaoyongjie @MaxHuiYYDS @junlincc @jinghua-qa