Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Superset Version Number in the UI #13674

Open
srinify opened this issue Mar 17, 2021 · 9 comments
Open

Clarify Superset Version Number in the UI #13674

srinify opened this issue Mar 17, 2021 · 9 comments
Assignees

Comments

@srinify
Copy link
Contributor

srinify commented Mar 17, 2021

Screenshot

Screen Shot 2021-03-17 at 2 23 08 PM

Description

I've been seeing Superset users, at least once a week, get tripped by the fact that the Version number displayed in the Superset UI is always 0.999.0dev if people are using the latest tag or using bleeding edge master from Github.

Here's a recent user that was confused, wondering why they aren't on Superset v1.1: https://apache-superset.slack.com/archives/C0170U650CQ/p1616004990065000

Potential Solutions

Ideal User Experience:
It Just Works (TM). Wherever possible, show the real version (using the git sha as the 'data source') for this. No doubt this will require extra work, but this would enhance the first day / first week user experience!

Less than ideal but more helpful
Keep the git sha but remove the version number from the UI

@junlincc junlincc added enhancement:request Enhancement request submitted by anyone from the community and removed change:ui preset-io labels Mar 18, 2021
@junlincc
Copy link
Member

this seems to be a highly requested change and will benefit all Superset users. @mayurnewase can you take a look? 🙏

@junlincc junlincc added enhancement:committed Enhancement planned / committed by a contributor and removed enhancement:request Enhancement request submitted by anyone from the community labels Nov 11, 2021
@junlincc junlincc added this to review in progress in Community issues Nov 15, 2021
@zhaoyongjie
Copy link
Member

In order to convenient debugging, not only add the current version but also show the commit hash here.

@rusackas rusackas assigned craig-rueda and villebro and unassigned mayurnewase Dec 13, 2021
@rusackas
Copy link
Member

I'm not quite sure the best way to handle this, but I think the release maker script might be one option to set/bump this number in the file. It would still be overridable by orgs by changing the config of their deployment.

@villebro
Copy link
Member

Let me review and test the PR by @mayurnewase this week so we can get it merged. I think the PR should work in most cases, but I just want to test a few more edge cases.

@layoaster
Copy link

Not exactly the same issue but deeply related: It is also important to start support for versioned tags on official Docker images.

Not being able to pin down to a specific Superset (Docker image) version is really frustrating and insecure.

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@sanjayssk
Copy link

Having same problem where embedDashboard works on an earlier image and fails on the latest one with 403. How do I find the exact version of the earlier image?

@stale stale bot removed the inactive Inactive for >= 30 days label Jul 26, 2022
@muneerj
Copy link

muneerj commented Oct 10, 2023

I can see this issue still exists in the 3.0.0 release. Any chance of having this rolled out to the latest build? We really should be able to show the correct version in the front-end.

@rusackas rusackas removed the enhancement:committed Enhancement planned / committed by a contributor label Mar 19, 2024
@rusackas
Copy link
Member

The 3.0 (or any) release should have the proper version number if you're running the actual release. Anything pulled from master is not an official version, so it will show a placeholder and a (hopefully) correct SHA.

Lately, it shows 0.0.0-dev as the placeholder. I wonder if we should just say "Unofficial Release" here or something, so people are less confused by it. Thoughts @kasiazjc @eschutho @michael-s-molina ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Community issues
review in progress
Development

No branches or pull requests

10 participants