-
Notifications
You must be signed in to change notification settings - Fork 16.6k
chore: Take version from latest git tag, correct version in package.json #17414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17414 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 1049 1049
Lines 56682 56682
Branches 7851 7851
=======================================
Hits 43539 43539
Misses 12890 12890
Partials 253 253
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Thank you so much @mayurnewase ! will test it locally. |
|
/testenv up |
|
@junlincc Ephemeral environment spinning up at http://34.208.96.8:8080. Credentials are |
|
currently it will take from latest release tag from github. |
|
@mayurnewase thank you! lmk when it's ready 🙏 |
fd15d79 to
4e3b728
Compare
|
@junlincc now it should show 1.3.2 |
villebro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the git-based automation was removed. I think it's important to distinguish a real release (1.3.2) from master branch or a custom tag/branch. I kinda liked using git for it; was there a reason for reverting that code?
|
@villebro I had used |
|
Something like |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
|
Ephemeral environment shutdown and build artifacts deleted. |

Update version in package.json
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Install superset
Start server
Check version shown on welcome page under setting dropdown.
ADDITIONAL INFORMATION