Skip to content

Conversation

@mayurnewase
Copy link
Contributor

@mayurnewase mayurnewase commented Nov 12, 2021

Update version in package.json

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Install superset
Start server
Check version shown on welcome page under setting dropdown.

ADDITIONAL INFORMATION

  • Has associated issue: Clarify Superset Version Number in the UI #13674
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@mayurnewase mayurnewase changed the title Take version from latest git tag, bump version in package.json [chore]: Take version from latest git tag, bump version in package.json Nov 12, 2021
@mayurnewase mayurnewase changed the title [chore]: Take version from latest git tag, bump version in package.json chore: Take version from latest git tag, bump version in package.json Nov 12, 2021
@mayurnewase mayurnewase changed the title chore: Take version from latest git tag, bump version in package.json chore: Take version from latest git tag, correct version in package.json Nov 12, 2021
@mayurnewase mayurnewase requested a review from villebro November 12, 2021 03:22
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #17414 (e1a67bc) into master (ebb3419) will not change coverage.
The diff coverage is n/a.

❗ Current head e1a67bc differs from pull request most recent head 4e3b728. Consider uploading reports for the commit 4e3b728 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17414   +/-   ##
=======================================
  Coverage   76.81%   76.81%           
=======================================
  Files        1049     1049           
  Lines       56682    56682           
  Branches     7851     7851           
=======================================
  Hits        43539    43539           
  Misses      12890    12890           
  Partials      253      253           
Flag Coverage Δ
javascript 71.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb3419...4e3b728. Read the comment docs.

@junlincc
Copy link
Member

Thank you so much @mayurnewase ! will test it locally.

@junlincc
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://34.208.96.8:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc
Copy link
Member

looks like it only show the helm chart version? is it possible to show either 1.3.2 or latest master?
Screen Shot 2021-11-12 at 2 52 35 PM

@mayurnewase
Copy link
Contributor Author

mayurnewase commented Nov 15, 2021

currently it will take from latest release tag from github.
will update it to take it only what we put in package.json file,so we can put whatever we want.

@junlincc
Copy link
Member

@mayurnewase thank you! lmk when it's ready 🙏

@mayurnewase
Copy link
Contributor Author

@junlincc now it should show 1.3.2

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the git-based automation was removed. I think it's important to distinguish a real release (1.3.2) from master branch or a custom tag/branch. I kinda liked using git for it; was there a reason for reverting that code?

@mayurnewase
Copy link
Contributor Author

mayurnewase commented Jan 5, 2022

@villebro I had used git describe --tags --abbrev=0 to get latest git tag available on current local branch, but it was showing helm charts tags as they were latest.
Should we get latest 50 tags and filter by regex to show latest superset release tag?
I will do this on priority.

@mayurnewase
Copy link
Contributor Author

Something like git tag --sort=committerdate | tail -50 | grep -e "^\d" | tail -1

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 16, 2022
@stale stale bot closed this Apr 28, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inactive Inactive for >= 30 days size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants