Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is adding new viz different now? #1406

Closed
github35 opened this issue Oct 21, 2016 · 8 comments
Closed

Is adding new viz different now? #1406

github35 opened this issue Oct 21, 2016 · 8 comments

Comments

@github35
Copy link

@mistercrunch

I like Caravel a lot and am trying to adding other nvd3 viz into it. I found below examples, and followed, but it didn't work -- I got an error message from explore.js when I selected the new viz in creating slice. I wonder if the process is different now and there are other files I need to change? Many thanks!

https://github.com/airbnb/caravel/pulls?q=is%3Apr+label%3Aexample+is%3Aclosed

@github35
Copy link
Author

The detailed error message is as below:
explore.0.11.0.entry.js -- s.default[t.form_data.viz_type] is not a function

@xrmx
Copy link
Contributor

xrmx commented Oct 21, 2016

Do you have any backtrace in the caravel python app logs? Have you added your class to caravel.viz.viz_types_list ?

@github35
Copy link
Author

Yes I did and I could select the new Viz from the drop down list, but it just didn't work . I also added in ../../visualizations/main.js vizMap.

@github35 github35 reopened this Oct 22, 2016
@github35
Copy link
Author

github35 commented Oct 22, 2016

The problem is the JS I added is not included in explore.0.11.0.entry.js (other viz are there). Is there anything I need to do to generate new explore.0.11.0.entry.js? Thank you for helping.

@ascott
Copy link
Contributor

ascott commented Oct 24, 2016

@github35 are you using npm run dev to build client side assets/js in development?

@github35
Copy link
Author

@ascott There seems to be a lot issues of building on Windows system. I will further explore any other possibilities. Thank you! Caravel is amazing. It will be great if we can customize visualization from browser, e.g. http://echarts.baidu.com/demo.html#heatmap-cartesian.

@xrmx
Copy link
Contributor

xrmx commented Nov 2, 2016

@github35 can we close this?

@github35
Copy link
Author

github35 commented Nov 7, 2016

@xrmx Sure. Thank you!

@github35 github35 closed this as completed Nov 7, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
* Replace color in scheme statically

* Set color statically and re-use instance

* Fix tests and clean up

* Improve comments

* Refactor and simplify

* Update tests

* Remove unnecessary ColorMapControl

* Remove unnecessary const

* Remove control label_colors
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
* Replace color in scheme statically

* Set color statically and re-use instance

* Fix tests and clean up

* Improve comments

* Refactor and simplify

* Update tests

* Remove unnecessary ColorMapControl

* Remove unnecessary const

* Remove control label_colors
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
* Replace color in scheme statically

* Set color statically and re-use instance

* Fix tests and clean up

* Improve comments

* Refactor and simplify

* Update tests

* Remove unnecessary ColorMapControl

* Remove unnecessary const

* Remove control label_colors
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
* Replace color in scheme statically

* Set color statically and re-use instance

* Fix tests and clean up

* Improve comments

* Refactor and simplify

* Update tests

* Remove unnecessary ColorMapControl

* Remove unnecessary const

* Remove control label_colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants