Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to disable Export to .csv format #14336

Closed
3 tasks done
abhishek-ch opened this issue Apr 25, 2021 · 2 comments
Closed
3 tasks done

Unable to disable Export to .csv format #14336

abhishek-ch opened this issue Apr 25, 2021 · 2 comments
Labels
#bug Bug report

Comments

@abhishek-ch
Copy link

Unable to disable/block user from Exporting to .csv, after removing can CSV on Superset permission from a custom role

Expected results

Export to .csv shouldn't work after removing the permission from the role.

Actual results

User can export the CSV by clicking the button
image

Screenshots

Removed all necessary permissions wrt to CSV but user can still export the CSV.
Permission looks below

image

How to reproduce the bug

  1. Login as Admin user
  2. Click on 'Settings > List Roles'
  3. Copy the role 'Alpha'
  4. Edit the copied alpha role and delete `can CSV on Superset' and save the role
  5. Assign the newly created role to a user
  6. Login with user details and go to charts and try to export the .csv
  7. User is still able to export the CSV

Environment

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

This was a bug previously but it was fixed!

@abhishek-ch abhishek-ch added the #bug Bug report label Apr 25, 2021
@duynguyenhoang
Copy link
Contributor

This PR #13713 expects to fix this problem. Recently I am quite busy with different stuffs, going to check it again.

@junlincc
Copy link
Member

@abhishek-ch let's follow up in @duynguyenhoang's PR #13713 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

3 participants