fix(explore): CSV Export Permission is incorrect on Explore page

[duynguyenhoang]

SUMMARY

• Add CSV Export permission when exporting CSV.
• Fix CSV Export permission on Expore page.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TEST PLAN

• Log in with user without "Can CSV on Superset" permission.
• Go to Dashboard page, verify there is no "Export CSV" in chart context menu.
• Click "View chart in Explore", verify that "Export CSV" button is disabled and unclickable.
• Try to access CSV export manually => 403 error returned with message { "error": "You don't have the rights to download as csv" }

ADDITIONAL INFORMATION

• Has associated issue: Fixed [explore] CSV Export permission is not consistent between Dashboard and Explore window #13711
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #13713 (bbb4767) into master (1f8de1d) will increase coverage by 0.01%.
The diff coverage is 92.85%.

❗ Current head bbb4767 differs from pull request most recent head b26cc92. Consider uploading reports for the commit b26cc92 to get more accurate results

@@            Coverage Diff             @@
##           master   #13713      +/-   ##
==========================================
+ Coverage   76.98%   76.99%   +0.01%     
==========================================
  Files         955      955              
  Lines       48085    48095      +10     
  Branches     6036     6038       +2     
==========================================
+ Hits        37020    37033      +13     
+ Misses      10867    10864       -3     
  Partials      198      198              

Flag	Coverage Δ
hive	80.75% <90.00%> (+<0.01%)	⬆️
javascript	71.71% <100.00%> (+0.02%)	⬆️
mysql	81.01% <90.00%> (+<0.01%)	⬆️
postgres	81.05% <90.00%> (+<0.01%)	⬆️
presto	80.74% <90.00%> (+<0.01%)	⬆️
python	81.57% <90.00%> (+<0.01%)	⬆️
sqlite	80.65% <90.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...tend/src/explore/components/ExploreChartHeader.jsx	63.15% <ø> (ø)
superset/views/core.py	75.66% <66.66%> (-0.04%)	⬇️
...nd/src/explore/components/ExploreActionButtons.tsx	72.34% <100.00%> (+10.11%)	⬆️
superset/charts/api.py	81.92% <100.00%> (+0.10%)	⬆️
superset/cli.py	51.47% <100.00%> (+0.48%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f8de1d...b26cc92. Read the comment docs.

[junlincc]

/testenv up

[github-actions]

@junlincc Ephemeral environment spinning up at http://34.222.8.128:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[junlincc]

Tested locally, LGTM! Sorry for the delay and thanks for the fix. do you mind rebasing since it has been quite a while. 🙏

[villebro]

Thanks for the fix! You should probably add it here, too (it's the new chart data endpoint that will ultimately replace explore_json):

superset/superset/common/query_context.py

Lines 152 to 160 in a3b41e2

	def get_data(self, df: pd.DataFrame,) -> Union[str, List[Dict[str, Any]]]:
	if self.result_format == ChartDataResultFormat.CSV:
	include_index = not isinstance(df.index, pd.RangeIndex)
	result = csv.df_to_escaped_csv(
	df, index=include_index, **config["CSV_EXPORT"]
	)
	return result or ""
	return df.to_dict(orient="records")

[duynguyenhoang]

@villebro PR is ready, please review it again.

[villebro]

LGTM - stellar PR with both frontend and backend tests! 🚀 Big thanks!

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.