Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent MySQL recommended connector #14746

Closed
3 tasks done
JPonte opened this issue May 21, 2021 · 3 comments
Closed
3 tasks done

Inconsistent MySQL recommended connector #14746

JPonte opened this issue May 21, 2021 · 3 comments
Assignees
Labels
#bug Bug report

Comments

@JPonte
Copy link

JPonte commented May 21, 2021

Two different documentation pages recommend different MySql connectors.
https://superset.apache.org/docs/databases/mysql recommends mysql-connector-python
https://superset.apache.org/docs/databases/installing-database-drivers recommends mysqlclient

Which one is the current recommended one or is it indifferent?

Expected results

Both pages recommend the same, either mysql-connector-python or mysqlclient.

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@JPonte JPonte added the #bug Bug report label May 21, 2021
@betodealmeida
Copy link
Member

Good catch! We should use mysql-connector-python, it works better with newer versions of MySQL. I'll update the docs.

@betodealmeida
Copy link
Member

Actually, I just saw this in the SQLAlchemy docs:

The MySQL Connector/Python DBAPI has had many issues since its release, some of which may remain unresolved, and the mysqlconnector dialect is not tested as part of SQLAlchemy’s continuous integration. The recommended MySQL dialects are mysqlclient and PyMySQL.

So I'll make mysqlclient the default. Though we had problems with it at Preset, and we had to switch to mysql-connector-python.

@betodealmeida
Copy link
Member

Updated docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants