Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update docs on MySQL recommended driver #14826

Merged
merged 3 commits into from May 25, 2021
Merged

chore: Update docs on MySQL recommended driver #14826

merged 3 commits into from May 25, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

Docs said that mysql-connector-python was recommended, but the SQLAlchemy docs say:

The MySQL Connector/Python DBAPI has had many issues since its release, some of which may remain unresolved, and the mysqlconnector dialect is not tested as part of SQLAlchemy’s continuous integration. The recommended MySQL dialects are mysqlclient and PyMySQL.

I updated the docs to recommend mysqlclient (the previous recommendation), and to inform when mysql-connector-python might be needed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Inconsistent MySQL recommended connector #14746
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida changed the title Update docs chore: Update docs on MySQL recommended driver May 25, 2021
@hughhhh hughhhh self-requested a review May 25, 2021 21:29
betodealmeida and others added 2 commits May 25, 2021 14:32
@betodealmeida @hughhhh
Update docs/src/pages/docs/Connecting to Databases/mysql.mdx
72e3d00 
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
@betodealmeida @hughhhh
Update docs/src/pages/docs/Connecting to Databases/mysql.mdx
23e2493 
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
@betodealmeida betodealmeida merged commit 4502086 into apache:master May 25, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@betodealmeida @hughhhh
chore: Update docs on MySQL recommended driver (apache#14826)
ff0a0ba 
* Update docs

* Update docs/src/pages/docs/Connecting to Databases/mysql.mdx

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>

* Update docs/src/pages/docs/Connecting to Databases/mysql.mdx

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@betodealmeida @hughhhh
chore: Update docs on MySQL recommended driver (apache#14826)
8797d1e 
* Update docs

* Update docs/src/pages/docs/Connecting to Databases/mysql.mdx

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>

* Update docs/src/pages/docs/Connecting to Databases/mysql.mdx

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@betodealmeida @hughhhh
chore: Update docs on MySQL recommended driver (apache#14826)
d53408d 
* Update docs

* Update docs/src/pages/docs/Connecting to Databases/mysql.mdx

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>

* Update docs/src/pages/docs/Connecting to Databases/mysql.mdx

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughhhh hughhhh hughhhh approved these changes

@srinify srinify Awaiting requested review from srinify

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@betodealmeida @hughhhh @mistercrunch