Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native-filters][select]multiple select dropdown open from the top #15029

Closed
junlincc opened this issue Jun 7, 2021 · 2 comments · Fixed by #15141
Closed

[native-filters][select]multiple select dropdown open from the top #15029

junlincc opened this issue Jun 7, 2021 · 2 comments · Fixed by #15141
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed dashboard:native-filters Related to the native filters of the Dashboard P2 Priority item - High test:case
Projects
Native dashboard filters

Comments

@junlincc
Copy link
Member

junlincc commented Jun 7, 2021 •
edited

Expected behavior: when user reopen the select dropdown with a bunch of selected filters, the dropdown should have a initial focus at the top to show all the selected items.
Current behavior: drop down takes user to the bottom. :(

Screen.Recording.2021-06-07.at.4.06.17.PM.mov

@geido @michael-s-molina @villebro 🙏
@junlincc junlincc added P2 Priority item - High dashboard:native-filters Related to the native filters of the Dashboard #bug:cosmetic Cosmetic/layout/design tweak needed labels Jun 7, 2021
@junlincc junlincc added this to To do in Native dashboard filters via automation Jun 7, 2021
@villebro
Copy link
Member

villebro commented Jun 8, 2021

I agree that it should open up from the top. @michael-s-molina @geido one for the Select redesign!

@michael-s-molina
Copy link
Member

Wow, nice catch!

@michael-s-molina michael-s-molina mentioned this issue Jun 13, 2021
Merged
8 tasks
Native dashboard filters automation moved this from To do to Done Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed dashboard:native-filters Related to the native filters of the Dashboard P2 Priority item - High test:case
Projects
No open projects
Native dashboard filters
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Scrolls top when opening a select filter michael-s-molina/incubator-superset
3 participants
@villebro @junlincc @michael-s-molina