chore: Scrolls top when opening a select filter #15141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15141 +/- ##
=======================================
Coverage 77.26% 77.26%
=======================================
Files 969 969
Lines 49918 49924 +6
Branches 6393 6395 +2
=======================================
+ Hits 38567 38573 +6
Misses 11148 11148
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kgabryje
reviewed
Jun 14, 2021
| @@ -275,14 +292,15 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) { | |||
| onSearch={searchWrapper} | |||
| onSelect={clearSuggestionSearch} | |||
| onBlur={handleBlur} | |||
| onDropdownVisibleChange={setIsDropdownVisible} | |||
| onDropdownVisibleChange={onDropdownVisibleChange} | |||
There was a problem hiding this comment.
I think we can use a different (maybe a bit simpler?) approach here
Suggested change
| onDropdownVisibleChange={onDropdownVisibleChange} | |
| dropdownRender={originNode => { | |
| if (isDropdownVisible && !wasDropdownVisible) { | |
| originNode.ref?.current?.scrollTo(0); | |
| } | |
| return originNode; | |
| }} |
and before that:
const wasDropdownVisible = usePrevious(isDropdownVisible);
What do you think?
There was a problem hiding this comment.
I think it's a really great solution. Much more elegant! I'll make the changes and test it. Thank you!
michael-s-molina
force-pushed
the
scroll-top-on-select-open
branch
from
a665a1c
to
3d6c6d2
Compare
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #15029
@rusackas @junlincc @villebro
@geido If we add the
inverseSelectionprop to the new Select, then this logic will be needed.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
121098597-10325080-c7ab-11eb-88fb-dca5d032959d_kUroVy7a.mov
screen-recording-2021-06-13-at-25900-pm_cGjyCPjl.mov
TESTING INSTRUCTIONS
See before/after videos for instructions.
ADDITIONAL INFORMATION