[chart-viz][time-series bar chart] SORT DESCENDING did not take effect when selected

[jinghua-qa]

SORT DESCENDING did not take effect when selected

Expected results

When 'SORT DESCENDING' is selected , expect SQL query and Data will sort in descending order

Actual results

When 'SORT DESCENDING', did not see DES in expect SQL query and Data is not sorted in descending order

Screenshots

How to reproduce the bug

1. Open time-series-bar chart
2. Click on 'SORT DESCENDING'
3. Select 'View query' and observe data
4. See error

Environment

• superset version: master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

[villebro]

I believe you need to populate the metric that you wish to sort by in the "Sort by" control for "Descending" to take effect. See here:

[jinghua-qa]

@villebro so should we disable the SORT option if SORT By is not configured?

[villebro]

@jinghua-qa that's probably a good idea 👍 I'll do that unless there is a reason why it should be active.