fix(explore): make SORT DESCENDING visible if SORT BY has value

[stephenLYZ]

SUMMARY

enhancement: Currently, if SORT BY is not set, SORT DESCENDING is not effective, for this reason, it will mislead the user, here we change it to show this control only if sort by is set.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: [chart-viz][time-series bar chart] SORT DESCENDING did not take effect when selected #15212
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #17726 (4152dd4) into master (4beaa81) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #17726      +/-   ##
==========================================
- Coverage   67.79%   67.77%   -0.02%     
==========================================
  Files        1605     1605              
  Lines       64207    64224      +17     
  Branches     6790     6791       +1     
==========================================
+ Hits        43529    43530       +1     
- Misses      18822    18838      +16     
  Partials     1856     1856              

Flag	Coverage Δ
javascript	54.80% <0.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ns/legacy-plugin-chart-horizon/src/controlPanel.ts	50.00% <0.00%> (-50.00%)	⬇️
...acy-plugin-chart-paired-t-test/src/controlPanel.ts	50.00% <0.00%> (-50.00%)	⬇️
...gin-chart-parallel-coordinates/src/controlPanel.ts	50.00% <0.00%> (-50.00%)	⬇️
...legacy-plugin-chart-partition/src/controlPanel.tsx	25.00% <0.00%> (-8.34%)	⬇️
...egacy-plugin-chart-pivot-table/src/controlPanel.ts	50.00% <0.00%> (-50.00%)	⬇️
...gins/legacy-plugin-chart-rose/src/controlPanel.tsx	50.00% <0.00%> (-50.00%)	⬇️
...ns/legacy-plugin-chart-treemap/src/controlPanel.ts	50.00% <0.00%> (-50.00%)	⬇️
...gacy-preset-chart-nvd3/src/DistBar/controlPanel.ts	10.00% <0.00%> (-1.12%)	⬇️
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx	95.83% <0.00%> (-4.17%)	⬇️
...chart-echarts/src/Timeseries/Area/controlPanel.tsx	40.00% <0.00%> (-10.00%)	⬇️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4beaa81...4152dd4. Read the comment docs.

[riahk]

So if SORT BY is set, does it sort descending by default?

[stephenLYZ]

So if SORT BY is set, does it sort descending by default?

Right.

[villebro]

Removed 1.4.2 label as this cherry requires monorepo which isn't available on the 1.4 branch

[ElevenDog]

why exist default sort(sort by x-field) this maybe cause The Chart Result data difference to sqlab query result